Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

map_ramps contain vision blockers and dont contain blocked ramps #248

Open
tweakimp opened this issue Feb 27, 2019 · 2 comments
Open

map_ramps contain vision blockers and dont contain blocked ramps #248

tweakimp opened this issue Feb 27, 2019 · 2 comments
Assignees
@tweakimp

Comments

@tweakimp
Copy link
Contributor

tweakimp commented Feb 27, 2019 •
edited
Loading

Currently, gameinfo.map_ramps contains vision blockers because the current ramp point condition self.placement_grid[(x, y)] == 0 and self.pathing_grid[(x, y)] == 0 is also true for them.

I think it is easier to filter them out by checking if there are different heights in these wrong Ramp objects, but maybe we can also change the ramp point condition in _find_ramps,

On the other hand, ramps that are blocked by destructable rocks are not in map_ramps.
I dont know how to find them.
We have the position of each destructable, but that is only one position, not the whole ramp.
Can we maybe get a footprint of it by its type_id?
@tweakimp tweakimp self-assigned this Feb 27, 2019
@tweakimp tweakimp mentioned this issue May 5, 2019
Merged
@tweakimp
Copy link
Contributor Author

tweakimp commented May 5, 2019

Fixed in #275

@tweakimp tweakimp closed this as completed May 5, 2019
@tweakimp tweakimp reopened this May 5, 2019
@tweakimp
Copy link
Contributor Author

tweakimp commented May 5, 2019

Only partly fixed...

ramps blocked by rocks are still not counted as ramps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tweakimp tweakimp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tweakimp