Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form mixin should include checkbox and radio mixins #24

Open
symroe opened this issue May 20, 2021 · 0 comments
Open

Form mixin should include checkbox and radio mixins #24

symroe opened this issue May 20, 2021 · 0 comments

Comments

@symroe
Copy link
Member

symroe commented May 20, 2021

At the moment, when including _forms.scss you also have to include _checkbox.scss and _radio.scss if you want to use those elements.

As I understand it, the point of optionally including the partials is to reduce the finial file size, however I think in this case it's a little too find grained: if you plan on using forms (by including _forms.sss) then you have no real idea of if a form in your application will use checkbox or radio elements in future.

More importantly, it's very possible that the person adding the checkboxes isn't the same person that added the CSS, and it might not get noticed (as they are styled as browser default anyway).

Solution: I think we should add the checkbox and radio elements in to _form.scss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant