Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalise how we determine what to pass through/remove/transform from upstream APIs #99

Open
chris48s opened this issue Nov 4, 2019 · 0 comments

Comments

@chris48s
Copy link
Member

chris48s commented Nov 4, 2019

The way we pass through data from upstream APIs is currently a bit haphazard:

  • Sometimes we just pass objects through, so if we change the upstream API, the change just automatically happens here too
  • Sometimes we explicitly pick out specific fields, so an upstream change that we want to reflect here has to be explicitly accounted for
  • Sometimes we apply a transformation to the data

This is a bit inconsistent. The idea is currently a bit half-baked, but it feels like there is scope to make this all much more obvious/predictable/consistent at all layers of the object hierarchy by applying a schema to the input and output data instead of adding ad-hoc rules, but I need to put more thought into it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant