Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Password field in hardcoded in values.yaml file #17

Open
tylerezimmerman opened this issue Sep 22, 2022 · 2 comments
Open

Password field in hardcoded in values.yaml file #17

tylerezimmerman opened this issue Sep 22, 2022 · 2 comments
Labels
security fix Security fix generated by Mend

Comments

@tylerezimmerman
Copy link
Contributor

tylerezimmerman commented Sep 22, 2022

(https://github.com/DelineaXPM/tss-k8s/blob/master/charts/tss-injector/values.yaml)

Please find a way to fetch the password from SecretServer, rather than having it hard coded.

image

@tylerezimmerman tylerezimmerman added the security fix Security fix generated by Mend label Sep 22, 2022
@sheldonhull
Copy link
Contributor

sheldonhull commented Sep 26, 2022

This is needed, because this client credential is what the syncer and injector use to connect to SS. This credential is valid and required to allow the syncing.

It's a helm input value, so we could improve it with the read from credentials.json as input for the helm value rather than coding the example in the chart.

@ErikLundJensen
Copy link

I don't know if this operator is still maintained, but the helm chart support using an existing secret for the credentials:
rolesJsonSecretName

Thereby this issue can be closed, right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
security fix Security fix generated by Mend
Projects
None yet
Development

No branches or pull requests

3 participants