From ca37f03a45bced4f0d7537765704de5ba1bdfaa8 Mon Sep 17 00:00:00 2001
From: david <mrminecraft00@gmail.com>
Date: Sat, 14 Dec 2024 11:21:26 +0100
Subject: [PATCH] Refactor Hologram constructors to enforce non-null config

Updated constructors to require non-null `FileConfig` and added an overloaded constructor with a `saveToFile` parameter. Simplified `delete()` method by removing a null check on the config.
---
 .../holograms/api/holograms/Hologram.java     | 28 +++++++++++++------
 1 file changed, 19 insertions(+), 9 deletions(-)

diff --git a/src/main/java/eu/decentsoftware/holograms/api/holograms/Hologram.java b/src/main/java/eu/decentsoftware/holograms/api/holograms/Hologram.java
index f2e99353..d49703f5 100644
--- a/src/main/java/eu/decentsoftware/holograms/api/holograms/Hologram.java
+++ b/src/main/java/eu/decentsoftware/holograms/api/holograms/Hologram.java
@@ -27,7 +27,6 @@
 import org.bukkit.entity.Player;
 import org.jetbrains.annotations.Contract;
 import org.jetbrains.annotations.NotNull;
-import org.jetbrains.annotations.Nullable;
 
 import java.io.File;
 import java.util.Collection;
@@ -266,7 +265,7 @@ public Hologram(@NonNull String name, @NonNull Location location) {
      * @see eu.decentsoftware.holograms.api.DHAPI#createHologram(String, Location, boolean)
      */
     public Hologram(@NonNull String name, @NonNull Location location, boolean saveToFile) {
-        this(name, location, saveToFile ? new FileConfig(DECENT_HOLOGRAMS.getPlugin(), String.format("holograms/%s.yml", name)) : null);
+        this(name, location, new FileConfig(DECENT_HOLOGRAMS.getPlugin(), String.format("holograms/%s.yml", name)), true, saveToFile);
     }
 
     /**
@@ -276,7 +275,7 @@ public Hologram(@NonNull String name, @NonNull Location location, boolean saveTo
      * @param location The location of the hologram.
      * @param config   The config of the hologram.
      */
-    public Hologram(@NonNull String name, @NonNull Location location, @Nullable FileConfig config) {
+    public Hologram(@NonNull String name, @NonNull Location location, @NonNull FileConfig config) {
         this(name, location, config, true);
     }
 
@@ -288,12 +287,25 @@ public Hologram(@NonNull String name, @NonNull Location location, @Nullable File
      * @param config   The config of the hologram.
      * @param enabled  Whether the hologram should be enabled.
      */
-    public Hologram(@NonNull String name, @NonNull Location location, @Nullable FileConfig config, boolean enabled) {
+    public Hologram(@NonNull String name, @NonNull Location location, @NonNull FileConfig config, boolean enabled) {
+        this(name, location, config, enabled, true);
+    }
+
+    /**
+     * Creates a new Hologram with the given parameters.
+     *
+     * @param name       The name of the hologram.
+     * @param location   The location of the hologram.
+     * @param config     The config of the hologram.
+     * @param enabled    Whether the hologram should be enabled.
+     * @param saveToFile Whether the hologram should be saved to a file.
+     */
+    public Hologram(@NonNull String name, @NonNull Location location, @NonNull FileConfig config, boolean enabled, boolean saveToFile) {
         super(location);
-        this.name = name;
         this.config = config;
         this.enabled = enabled;
-        this.saveToFile = this.config != null;
+        this.name = name;
+        this.saveToFile = saveToFile;
         this.tickCounter = new AtomicInteger();
         this.addPage();
         this.register();
@@ -346,9 +358,7 @@ public String toString() {
     @Override
     public void delete() {
         super.delete();
-        if (config != null) {
-            config.delete();
-        }
+        config.delete();
     }
 
     /**