Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folia Support for DecentHolograms? #123

Open
3 tasks done
Agaloth opened this issue Mar 29, 2023 · 11 comments
Open
3 tasks done

Folia Support for DecentHolograms? #123

Agaloth opened this issue Mar 29, 2023 · 11 comments
Labels
enhancement New feature or request

Comments

@Agaloth
Copy link

Agaloth commented Mar 29, 2023

Just making sure

  • I have read the wiki and made sure, this feature is not yet in the plugin.
  • I believe, that this feature is possible to implement.
  • I made sure, that this feature has not been requested yet.

Problem

There is no Folia Support for DecentHolograms yet (since it just came out)

Feature

https://github.com/PaperMC/Folia

Here is a summary of everything made with ChatGPT to save some time:

For plugin developers, there are a few key takeaways from the given text:

  1. Folia introduces regionised multithreading, which means that plugins will require modification to function properly. Plugin developers should expect compatibility with existing plugins to be at zero.

  2. Folia introduces new API additions, such as the RegionisedScheduler and EntityScheduler, which can help plugins run on the correct thread context.

  3. To ensure compatibility with Folia, plugin developers must mark their plugin as compatible by placing "folia-supported: true" in the plugin.yml file. Additionally, plugins must take advantage of the RegionisedScheduler and EntityScheduler API to ensure correct behavior.

  4. Plugins should not assume that they can access or modify data in other regions, as Folia regions tick in parallel and do not share data. Plugin developers should take advantage of the upcoming thread-check API to ensure correct behavior.

  5. There are currently broken API, including the scoreboard API, and planned API changes, such as super aggressive thread checks, which may impact plugin development.

Overall, plugin developers should be prepared for significant changes in their plugins to ensure compatibility with Folia. They should take advantage of the new API additions and mark their plugin as compatible to ensure correct behavior. Additionally, they should be aware of the limitations and rules of Folia's regionised multithreading to avoid bugs and errors in their plugins.

Alternatives

No response

@Aitooor
Copy link

Aitooor commented Apr 27, 2023

Will it this possible?

@mani1232
Copy link

@cgw2023
Copy link

cgw2023 commented Jun 26, 2023

Try: https://github.com/mani1232/DecentHolograms

Is there any jar can download for testing?

@mani1232
Copy link

Try: https://github.com/mani1232/DecentHolograms

Is there any jar can download for testing?

DecentHolograms-2.8.3-all.zip

@cgw2023
Copy link

cgw2023 commented Nov 10, 2023

Try: https://github.com/mani1232/DecentHolograms

Is there any jar can download for testing?

DecentHolograms-2.8.3-all.zip

is there a 1.20.2 version?

@mani1232
Copy link

Try: https://github.com/mani1232/DecentHolograms

Is there any jar can download for testing?

DecentHolograms-2.8.3-all.zip

is there a 1.20.2 version?

Compile https://github.com/mani1232/DecentHolograms for latest version

@cgw2023
Copy link

cgw2023 commented Nov 28, 2023

Try: https://github.com/mani1232/DecentHolograms

Is there any jar can download for testing?

DecentHolograms-2.8.3-all.zip

is there a 1.20.2 version?

Compile https://github.com/mani1232/DecentHolograms for latest version

i have error of

[20:42:23 ERROR]: [DecentHolograms] Error initializing plugin 'DecentHolograms-2.8.4.jar' in folder 'plugins' (Is it up to date?)
java.lang.NoClassDefFoundError: space/arim/morepaperlib/MorePaperLib
        at eu.decentsoftware.holograms.api.DecentHologramsAPI.onLoad(DecentHologramsAPI.java:37) ~[DecentHolograms-2.8.4.jar:?]
        at eu.decentsoftware.holograms.plugin.DecentHologramsPlugin.onLoad(DecentHologramsPlugin.java:18) ~[DecentHolograms-2.8.4.jar:?]
        at io.papermc.paper.plugin.storage.ServerPluginProviderStorage.processProvided(ServerPluginProviderStorage.java:59) ~[folia-1.20.2.jar:git-Folia-"7aacf90"]
        at io.papermc.paper.plugin.storage.ServerPluginProviderStorage.processProvided(ServerPluginProviderStorage.java:18) ~[folia-1.20.2.jar:git-Folia-"7aacf90"]
        at io.papermc.paper.plugin.storage.SimpleProviderStorage.enter(SimpleProviderStorage.java:40) ~[folia-1.20.2.jar:git-Folia-"7aacf90"]
        at io.papermc.paper.plugin.entrypoint.LaunchEntryPointHandler.enter(LaunchEntryPointHandler.java:36) ~[folia-1.20.2.jar:git-Folia-"7aacf90"]
        at org.bukkit.craftbukkit.v1_20_R2.CraftServer.loadPlugins(CraftServer.java:520) ~[folia-1.20.2.jar:git-Folia-"7aacf90"]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:273) ~[folia-1.20.2.jar:git-Folia-"7aacf90"]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1173) ~[folia-1.20.2.jar:git-Folia-"7aacf90"]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:343) ~[folia-1.20.2.jar:git-Folia-"7aacf90"]
        at java.lang.Thread.run(Thread.java:842) ~[?:?]
Caused by: java.lang.ClassNotFoundException: space.arim.morepaperlib.MorePaperLib
        at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:197) ~[folia-api-1.20.2-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:164) ~[folia-api-1.20.2-R0.1-SNAPSHOT.jar:?]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
        ... 11 more

after compile , what should i do?

@mani1232
Copy link

If you need Folia support, dm me in discord: mani123

@d0by1
Copy link
Member

d0by1 commented Nov 30, 2023

If you need Folia support, dm me in discord: mani123

You can make a Pull Request to add the support to DecentHolograms. I would merge such a feature.

@mani1232
Copy link

#175 here

@d0by1 d0by1 added the enhancement New feature or request label Jan 13, 2024
@Xyness
Copy link

Xyness commented Sep 9, 2024

Hi, any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants