Skip to content
This repository has been archived by the owner on Aug 24, 2023. It is now read-only.

docker caching is currently not supported due to limitations of cargo/issues/2644. However, there are ways around this. #164

Open
fuxingloh opened this issue Nov 23, 2022 · 3 comments
Labels
area/workflow kind/feature New feature request triage/accepted Triage has been accepted

Comments

@fuxingloh
Copy link
Contributor

fuxingloh commented Nov 23, 2022

Docker caching is currently not supported due to limitations of cargo/issues/2644. However, there are ways around this.

Ideally, the case scenario is to run cargo fetch on just the Cargo.lock file. However, that cannot run unless src/* are present which defeats the whole point of layered docker caching.

Alternatively:

  • we could setup empty projects with mocked src/* structure and use Cargo.lock to RUN cargo fetch
  • other use something like cargo-chef

Originally posted by @fuxingloh in #163 (comment)

Why?

For better DX.

@defichain-bot defichain-bot added the needs/triage Waiting for triage to be accepted label Nov 23, 2022
@defichain-bot
Copy link
Member

@fuxingloh: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@defichain-bot defichain-bot added the needs/kind Needs kind label label Nov 23, 2022
@defichain-bot
Copy link
Member

@fuxingloh: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@defichain-bot defichain-bot added the needs/area Needs area label(s) label Nov 23, 2022
@fuxingloh
Copy link
Contributor Author

/kind feature
/area workflow

@defichain-bot defichain-bot added kind/feature New feature request area/workflow and removed needs/kind Needs kind label needs/area Needs area label(s) labels Nov 23, 2022
@fuxingloh fuxingloh added the triage/accepted Triage has been accepted label Nov 24, 2022
@defichain-bot defichain-bot removed the needs/triage Waiting for triage to be accepted label Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/workflow kind/feature New feature request triage/accepted Triage has been accepted
Projects
None yet
Development

No branches or pull requests

3 participants