From ce95119a73fdf65b963d30a05f5def4913251a04 Mon Sep 17 00:00:00 2001 From: Adam Velebil Date: Thu, 12 Sep 2024 14:49:12 +0200 Subject: [PATCH] review fixes --- .../src/main/kotlin/com/yubico/authenticator/MainActivity.kt | 5 +---- lib/fido/views/delete_credential_dialog.dart | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/android/app/src/main/kotlin/com/yubico/authenticator/MainActivity.kt b/android/app/src/main/kotlin/com/yubico/authenticator/MainActivity.kt index ae0b4a60f..a543dfc2d 100644 --- a/android/app/src/main/kotlin/com/yubico/authenticator/MainActivity.kt +++ b/android/app/src/main/kotlin/com/yubico/authenticator/MainActivity.kt @@ -349,17 +349,14 @@ class MainActivity : FlutterFragmentActivity() { logger.debug("Exception while getting device info and scp keys: ", e) contextManager?.onError(e) if (device is NfcYubiKeyDevice) { - logger.debug("Setting NFC state to failure") appMethodChannel.nfcStateChanged(NfcState.FAILURE) } - // do not clear the device info when IOException's occur, + // do not clear deviceInfo on IOExceptions, // this allows for retries of failed actions if (e !is IOException) { logger.debug("Resetting device info") deviceManager.setDeviceInfo(null) - } else { - logger.debug("Keeping device info") } return diff --git a/lib/fido/views/delete_credential_dialog.dart b/lib/fido/views/delete_credential_dialog.dart index d2ea2fbc3..1a7f49dfa 100755 --- a/lib/fido/views/delete_credential_dialog.dart +++ b/lib/fido/views/delete_credential_dialog.dart @@ -1,5 +1,5 @@ /* - * Copyright (C) 2022 Yubico. + * Copyright (C) 2022-2024 Yubico. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License.