Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load RoundsTable tabs #206

Open
DavidGolodetsky opened this issue Oct 30, 2021 · 0 comments
Open

Lazy load RoundsTable tabs #206

DavidGolodetsky opened this issue Oct 30, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@DavidGolodetsky
Copy link
Owner

Actual: When a user lands on the rounds page and he has some rounds there, the TheBarsChart.vue and TheTendenciesChart.vue components are loaded immediately, although user hasn't touched the tabs.

image

Expected: Only when user changes the tab the corresponding component should be loaded via dynamic imports.

Tech notes:
You can check the desired behaviour if you'll place a v-if directive on the actions slot. Then once it's truthy the component will be fetched via dynamic imports.
You can also make use of webpack magic comments to identify a chunk.
GamesEditDialog: () => import(/* webpackChunkName: 'GamesEditDialog' */ '@/components/GamesEditDialog.vue')

@DavidGolodetsky DavidGolodetsky added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant