You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking in TimeSystem.cs in ITime.GetNow at line 22 it's using DateTime.Now, but if the code is running in an environment where the clocks change from DST to non-DST then DateTime.Now will suddenly return 1 hour before - and vice versa if the clocks go forward.
So I think (and please do just say if I'm misreading the code!) that if a longer running delay is active at the point when the clocks change, that the limiter might return early, OR very very late.
Perhaps a straight switch to DateTime.UtcNow would resolve this?
The text was updated successfully, but these errors were encountered:
Hi,
Looking in TimeSystem.cs in
ITime.GetNow
at line 22 it's usingDateTime.Now
, but if the code is running in an environment where the clocks change from DST to non-DST then DateTime.Now will suddenly return 1 hour before - and vice versa if the clocks go forward.So I think (and please do just say if I'm misreading the code!) that if a longer running delay is active at the point when the clocks change, that the limiter might return early, OR very very late.
Perhaps a straight switch to
DateTime.UtcNow
would resolve this?The text was updated successfully, but these errors were encountered: