Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALX Tasks checker fails #37

Open
3 tasks
M1-Elmasry opened this issue Aug 5, 2024 · 10 comments
Open
3 tasks

ALX Tasks checker fails #37

M1-Elmasry opened this issue Aug 5, 2024 · 10 comments
Assignees

Comments

@M1-Elmasry
Copy link
Collaborator

M1-Elmasry commented Aug 5, 2024

  • Tasks to resolve:
    • Task 4
    • Task 5
    • Task 8
@Davenchy

This comment was marked as resolved.

@M1-Elmasry
Copy link
Collaborator Author

it's wrong output checks, anyway, i checked the task 4 endpoints (/connect, /disconnect, /users/me) response and status codes same as required

@Davenchy
Copy link
Owner

Davenchy commented Aug 6, 2024

Also, task 6 has 3 fails : 9, 11 and 12

So far we have the following fails:

  • Task 4: 5, 8
  • Task 5: 4, 6, 7, 11, 13
  • Task 6: 9, 11, 12

Task 1 exhibits inconsistent behavior: it sometimes passes completely, while other times it fails at check 4. This occurs without any code changes, simply by rerunning the check.

@Davenchy

This comment was marked as outdated.

@Davenchy Davenchy changed the title Checks failed on tasks 4 and 5 ALX Tasks checker fails Aug 7, 2024
@Davenchy Davenchy pinned this issue Aug 7, 2024
@Davenchy

This comment was marked as outdated.

@Davenchy
Copy link
Owner

Davenchy commented Aug 7, 2024

After reverting code in #43 and #44 .
Task 8 fails: 6, 7, 11, 14, 15, 16.
7 passes / 6 fails

@M1-Elmasry
These are the differences after task 8, do you see any problem? b21481b...main

@Davenchy
Copy link
Owner

Davenchy commented Aug 8, 2024

Task 6 and 7 have been resolved

@Davenchy
Copy link
Owner

Davenchy commented Aug 8, 2024

In task 4, all old fails (7, 11) have been resolved, but check 5 fails.
I downloaded all the test cases, and they all pass. So, I have no idea what is the problem!?

Task 5 has 10 and 11 fails
Task 8 still has 5, 6, 7, 9, 10, 11 and 16

@M1-Elmasry
Copy link
Collaborator Author

When i was writing tests in task 10 i noticed there is test cases passes in the first try and then fails, after some debugging i knew that's happened because in the first try redis and db are clear there is no records in them, so try to dump some data into redis and db and run tests again

@Davenchy
Copy link
Owner

When i was writing tests in task 10 i noticed there is test cases passes in the first try and then fails, after some debugging i knew that's happened because in the first try redis and db are clear there is no records in them, so try to dump some data into redis and db and run tests again

This solves many problems while testing on my machine, but about the checker, I checked the testing codes for each check, and the tests do drop and recreate the db and collections and fill them with initial data. So, I don't think this affect the checker, but it does affect our local environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants