fix #55 memory leak in cJSON_ReplaceItemInObject

FSMaxB · FSMaxB · commit 0d10e279c8b6 · 2016-11-11T11:53:14.000+07:00
diff --git a/cJSON.c b/cJSON.c
@@ -1861,6 +1861,12 @@ void cJSON_ReplaceItemInObject(cJSON *object, const char *string, cJSON *newitem
     }
     if(c)
     {
+        /* free the old string if not const */
+        if (!(newitem->type & cJSON_StringIsConst) && newitem->string)
+        {
+             cJSON_free(newitem->string);
+        }
+
         newitem->string = cJSON_strdup(string);
         cJSON_ReplaceItemInArray(object, i, newitem);
     }

Original file line number	Diff line number	Diff line change
`@@ -1861,6 +1861,12 @@ void cJSON_ReplaceItemInObject(cJSON object, const char string, cJSON *newitem`
`1861`	`1861`	`}`
`1862`	`1862`	`if(c)`
`1863`	`1863`	`{`
	`1864`	`+ /* free the old string if not const */`
	`1865`	`+ if (!(newitem->type & cJSON_StringIsConst) && newitem->string)`
	`1866`	`+ {`
	`1867`	`+ cJSON_free(newitem->string);`
	`1868`	`+ }`
	`1869`	`+`
`1864`	`1870`	`newitem->string = cJSON_strdup(string);`
`1865`	`1871`	`cJSON_ReplaceItemInArray(object, i, newitem);`
`1866`	`1872`	`}`