-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] support duckdb #171
Comments
I'm keen to try this with DuckDB. What is the holdup on the merge here? Is there something wrong with the code? |
@adumicic Thanks for this question, you raise a really good point and a valid concern. Our contribution process does not currently allow direct contributions via PRs due to our proprietary development and test environment. We have over 3000 tests which extensively test the AutomateDV macros with different patterns, across all of our currently supported platforms. We are reluctant to approve PRs which have not gone through the test suite due to the nature of the product (data consistency, following the DV standards, etc.), however as public contributors do not have access to the test suite, it means we essentially cannot accept them. We do take contributions, but at this current time it involves working more collaboratively with us and going through a more formal process. We want to work towards having a more streamlined and publicly accessible contribution process, as it will benefit the community massively. I do appreciate the current situation is awkward, and it is something we want to resolve sooner rather than later. For now, leaving PRs open and making them visible to the community is what we are doing to compromise, rather than closing them. For this particular PR, I did reach out to the author and let them know about the situation, and they were happy for us to leave it open in this way. |
DuckDB is getting more and more useful and popular. I think it makes sense. |
Of course it makes sense. Why wouldn't we want everything running in a python project, without depending on external connections? |
+1 for duckdb. I think it will be a great teaching tool to get people into datavault. |
Is your feature request related to a problem? Please describe.
A situation arose where I wanted to use duckdb in local development.
I added duckdb as it does not seem to be currently supported.
Describe the solution you'd like
Please merge here
#170
I have confirmed that dbt seed and dbt run work.
AB#5369
The text was updated successfully, but these errors were encountered: