Fixed certain issues, appeared during changes in branch

Author: alex-kulakov

Orm/Xtensive.Orm/Modelling/Comparison/Upgrader.cs

@@ -119,8 +119,6 @@ public IReadOnlyList<NodeAction> GetUpgradeSequence(Difference difference, HintS
     /// <exception cref="InvalidOperationException">Upgrade sequence validation has failed.</exception>
     public IReadOnlyList<NodeAction> GetUpgradeSequence(Difference difference, HintSet hints, IComparer comparer)
     {
-      ArgumentNullException.ThrowIfNull(hints, nameof(hints));
-      ArgumentNullException.ThrowIfNull(comparer, nameof(comparer));
       if (difference == null) {
         return Array.Empty<NodeAction>();
       }
@@ -129,7 +127,7 @@ public IReadOnlyList<NodeAction> GetUpgradeSequence(Difference difference, HintS
       SourceModel = (IModel) difference.Source;
       TargetModel = (IModel) difference.Target;
       Hints = hints ?? new HintSet(SourceModel, TargetModel);
-      Comparer = comparer;
+      Comparer = comparer ?? throw new ArgumentNullException(nameof(comparer));
       if (Hints.SourceModel != SourceModel) {
         throw new ArgumentOutOfRangeException("hints.SourceModel");
       }

Orm/Xtensive.Orm/Orm/Internals/Prefetch/EntityContainer.cs

@@ -6,7 +6,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using Xtensive.Core;
 using Xtensive.Orm.Model;
 using Xtensive.Tuples;
@@ -17,8 +16,6 @@ namespace Xtensive.Orm.Internals.Prefetch
   [Serializable]
   internal abstract class EntityContainer
   {
-    private static readonly Parameter<Tuple> seekParameter = new Parameter<Tuple>(WellKnown.KeyFieldName);
-
     private SortedDictionary<int, ColumnInfo> columns;
 
     protected readonly PrefetchManager Manager;

Orm/Xtensive.Orm/Orm/Linq/Translator.Expressions.cs

@@ -506,6 +506,7 @@ protected override Expression VisitMethodCall(MethodCallExpression mc)
         if (methodDeclaringType == typeof(QueryableExtensions)) {
           return methodName switch {
             Reflection.WellKnown.QueryableExtensions.LeftJoin => VisitLeftJoin(mc),
+            Reflection.WellKnown.QueryableExtensions.LeftJoinEx => VisitLeftJoin(mc),
             Reflection.WellKnown.QueryableExtensions.In => VisitIn(mc),
             Reflection.WellKnown.QueryableExtensions.Lock => VisitLock(mc),
             Reflection.WellKnown.QueryableExtensions.Take => VisitTake(mc.Arguments[0], mc.Arguments[1]),

Orm/Xtensive.Orm/Orm/Linq/WellknownMembers.Queryable.cs

@@ -80,6 +80,7 @@ public static class Queryable
       // Queryable extensions
       public static readonly MethodInfo ExtensionCount = GetQueryableExtensionsMethod(nameof(QueryableExtensions.Count), 0, 1);
       public static readonly MethodInfo ExtensionLeftJoin = GetQueryableExtensionsMethod(nameof(QueryableExtensions.LeftJoin), 4, 5);
+      public static readonly MethodInfo ExtensionLeftJoinEx = GetQueryableExtensionsMethod(nameof(QueryableExtensions.LeftJoinEx), 4, 5);
       public static readonly MethodInfo ExtensionLock = GetQueryableExtensionsMethod(nameof(QueryableExtensions.Lock), 1, 3);
       public static readonly MethodInfo ExtensionTake = GetQueryableExtensionsMethod(nameof(QueryableExtensions.Take), 1, 2);
       public static readonly MethodInfo ExtensionSkip = GetQueryableExtensionsMethod(nameof(QueryableExtensions.Skip), 1, 2);

Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/FreeTextProvider.cs

@@ -49,7 +49,7 @@ public FreeTextProvider(
     {
       SearchCriteria = searchCriteria ?? throw new ArgumentNullException(nameof(searchCriteria));
       FullFeatured = fullFeatured;
-      TopN = topN ?? throw new ArgumentNullException(nameof(topN));
+      TopN = topN;
       PrimaryIndex = new IndexInfoRef(index.PrimaryIndex);
       if (FullFeatured) {
         var primaryIndexRecordsetHeader = index.PrimaryIndex.ReflectedType.Indexes.PrimaryIndex.GetRecordSetHeader();

Orm/Xtensive.Orm/Orm/Upgrade/Model/PrimaryIndexInfo.cs

@@ -56,7 +56,7 @@ protected override void ValidateState()
             throw new ValidationException(Strings.ExPrimaryKeyColumnCanNotBeNullable, Path);
           });
 
-        var values = ValueColumns.Select(valueRef => valueRef.Value).ToArray(KeyColumns.Count);
+        var values = ValueColumns.Select(valueRef => valueRef.Value).ToArray(ValueColumns.Count);
         var allCount = keys.Length + values.Length;
         if (allCount!=tableColumns.Count)
           ea.Execute(() => {

Orm/Xtensive.Orm/Orm/VersionCapturer.cs

@@ -130,8 +130,7 @@ public static VersionCapturer Attach(Session session, VersionSet versions)
     private VersionCapturer(Session session, VersionSet versions)
       : base(session)
     {
-      ArgumentNullException.ThrowIfNull(versions);
-      Versions = versions;
+      Versions = versions ?? throw new ArgumentNullException(nameof(versions));
       AttachEventHandlers();
     }
 

Orm/Xtensive.Orm/Reflection/WellKnown.QueryableExtensions.cs

@@ -13,6 +13,7 @@ public static class QueryableExtensions
     {
       public const string Count = nameof(Orm.QueryableExtensions.Count);
       public const string LeftJoin = nameof(Orm.QueryableExtensions.LeftJoin);
+      public const string LeftJoinEx = nameof(Orm.QueryableExtensions.LeftJoinEx);
       public const string Lock = nameof(Orm.QueryableExtensions.Lock);
       public const string Take = nameof(Orm.QueryableExtensions.Take);
       public const string Skip = nameof(Orm.QueryableExtensions.Skip);

Orm/Xtensive.Orm/Tuples/Transform/MapTransform.cs

@@ -294,6 +294,7 @@ public MapTransform(bool isReadOnly, TupleDescriptor descriptor, IReadOnlyList<i
     protected MapTransform(bool isReadOnly, TupleDescriptor descriptor)
       : this(isReadOnly)
     {
+      ArgumentValidator.EnsureArgumentIsNotDefault(descriptor, nameof(descriptor));
       Descriptor = descriptor;
       this.isReadOnly = isReadOnly;
     }