Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up stale ECSO branches #85

Open
amoeba opened this issue Apr 7, 2021 · 6 comments
Open

Clean up stale ECSO branches #85

amoeba opened this issue Apr 7, 2021 · 6 comments
Assignees
Labels
ECSO semantics Semantics: ontologies, annotation, search, etc.

Comments

@amoeba
Copy link
Collaborator

amoeba commented Apr 7, 2021

We have three long-standing and stale ECSO branches:

  • ECSO8-add_non-carbon_measurements
  • ArcticECSO
  • run4

Having these around is problematic from my perspective because it's not clear where new work should go and it's not clear which is the authoritative copy of ECSO. We were hoping to have someone more familiar with the work resolve these issues but I think I can probably do a decent job.

I took a look through and found some things out:

  • run4 appears to be lined up with master so we leave that branch is. Unfortunately, we released stuff in production that hardcodes that branch so I want to keep it there unless I can confidently update everything to a real release
  • ArcticECSO has work from https://github.com/Olson87 that mainly adds a new OWL file d1-ECSO.owl. Browse that here. Does anyone think we need to drill into that branch or can we just delete it since it was never merged with another branch
  • ECSO8-add_non-carbon_measurements can be cleanly merged because it just created an entirely new OWL file for its changes, ECSO8.owl. ECSO8.owl is what we've published in BioPortal and used in production services. See compare view for the branch

At this point I'm inclined to delete ArcticECSO, merge ECSO8-add_non-carbon_measurements into master and remove the existing ECSO4.owl file. I'm not sure it's worth going over it all with a fine-toothed comb.

@amoeba amoeba added the ECSO label Apr 7, 2021
@amoeba amoeba self-assigned this Apr 7, 2021
@mobb
Copy link
Contributor

mobb commented Apr 9, 2021

Thanks for entering this issue, @amoeba ! I can't comment on the ArcticECSO or the run4 branches. TTBOMK, ECSO8.owl is the primary one, which should become the head. @stevenchong and @mpsaloha did most of the work on that, so may want to comment.

In general, is this activity part of a larger effort of ECSO-management? if so, great! we (EDI) has been looking at ECSO, putting test annotations into EML, and would like to know a bit more about management plans so we can plan future work. Thanks again.

@mpsaloha
Copy link
Collaborator

mpsaloha commented Apr 9, 2021 via email

@stevenchong
Copy link
Contributor

I'm glad to see that this repo is getting cleaned up! ECSO8.owl is the primary file. It has all of the updates I made and it should be merged into the master branch.

The ECSO4.owl file was used as the basis for the ECSO8 file, so it's probably worth archiving along with the d1-ecso file. I don't recall working with the ArcticECSO branch when I was adding/editing terms in ECSO.

@amoeba
Copy link
Collaborator Author

amoeba commented Apr 9, 2021

Thanks @mobb, @mpsaloha, @stevenchong .

@mobb: We're continuing to incorporate semantics into our various projects and so we'd like to get things tidier, yeah. We have no plans to abandon ECSO and are actually hoping to keep it under active management for the foreseeable future.

Sounds like we're in agreement here that we can merge in the ECSO8 file @mpsaloha is working on once he's done and I can tidy things up from there. Thanks all.

@mbjones
Copy link
Member

mbjones commented Apr 15, 2021

@amoeba when you clean up, please don't delete branches unless you tag them beforehand so that we have a reference to the work at that point. Branches like run4 were used to flag the exact version we used for the earlier quantitative analysis runs, and we will benefit if it continues to be accessible for future inspection. tags seem appropriate if the branches are somehow annoying, but I would just leave the branch in place and tag it (ymmv).

@amoeba
Copy link
Collaborator Author

amoeba commented Apr 15, 2021

Thanks @mbjones, I'll probably leave that branch around since I know we've hardcoded it in various places. And adding a tag to go with it is a good idea.

@mbjones mbjones added the semantics Semantics: ontologies, annotation, search, etc. label Apr 29, 2021
@amoeba amoeba mentioned this issue Jul 14, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ECSO semantics Semantics: ontologies, annotation, search, etc.
Projects
None yet
Development

No branches or pull requests

5 participants