Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GHA automated builds #127

Open
mbjones opened this issue Jul 23, 2024 · 2 comments
Open

fix GHA automated builds #127

mbjones opened this issue Jul 23, 2024 · 2 comments

Comments

@mbjones
Copy link
Member

mbjones commented Jul 23, 2024

The Github Actions continuous integration builds a broken and not running due to:

  • old versions of the GHA workflow dependencies
  • incompatible pyLODE versions that are not working
  • metadata problems with various DataONE ontologies

Fix these and get the website building again.

@mbjones
Copy link
Member Author

mbjones commented Jul 23, 2024

As of sha 7622d47 the GHA build is working again for the ci.yaml workflow, and so the website is now building. The MOSAIC validation script is still failing, but it seems to be a problem with the verification of terms against Pangaea. Needs some digging.

@mbjones mbjones added this to the salmon-0.4.0 milestone Aug 3, 2024
@mbjones
Copy link
Member Author

mbjones commented Sep 5, 2024

I looked into the error from the MOSAiC checks, and the problem is indeed that the Pangaea web service is now producing a list of campaigns that includes identifiers that are not found in the ontology. Here'e the type of error returned:

| Exception: Campaign with label 'SO275' not found in the expected set ['PS122/5', 'PS122/4', 'P5_223_MOSAiC_ACA_2020', 'P5-223_MOSAiC_ACA_2020', 'PS122/1', 'PS122/2', 'PS122/3', 'AF-MOSAiC-1', 'P6_222_IceBird_MOSAiC_2020', 'P6-222_IceBird_MOSAiC_2020', 'AT-MOSAiC-1']

The list of identifiers from the ontology and pangaea site, and whether they match, are:

Ontology Pangaea Match?
PS122/5 PS122/5 yes
PS122/4 PS122/4 yes
PS122/1 PS122/1 yes
PS122/2 PS122/2 yes
PS122/3 PS122/3 yes
AF-MOSAiC-1 AF-MOSAiC-1 yes
AT-MOSAiC-1 AT-MOSAiC-1 yes
P5_223_MOSAiC_ACA_2020 P5-223_MOSAiC_ACA_2020 no
P6_222_IceBird_MOSAiC_2020 P6-222_IceBird_MOSAiC_2020 no
SO275 no
MSM92 no
KD-MOSAiC-1 no

For P5_223_MOSAiC_ACA_2020 and P6_222_IceBird_MOSAiC_2020, the only difference seems to be the _ character was changed to -, so a new rdfs:label can be added to those existing campaigns. For SO275, MSM92, and KD-MOSAiC-1, the campaigns need to be added to the ontology file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant