Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address some notes on the salmon ontology #108

Open
amoeba opened this issue Sep 16, 2021 · 2 comments
Open

Address some notes on the salmon ontology #108

amoeba opened this issue Sep 16, 2021 · 2 comments
Assignees
Labels
salmon data Open salmon data mobilization project

Comments

@amoeba
Copy link
Collaborator

amoeba commented Sep 16, 2021

While doing another scan of the salmon ontology (as checked into git), I'm noticing some things that seemed odd which we might look at.

  • Under "Total recruit abundance", we've broken out freshwater/saltwater ages in such a way that the freshwater age is the parent class of the total age.

    Screen Shot 2021-09-15 at 8 39 44 PM

    The parent classes with just freshwater age don't have definitions yet but maybe the label should be updated to say it's for al 0-ocean fish, not "age class 0" which sounds odd.

  • Recruits per spawner is a subclass of "Recruit abundance" which I guess isn't wrong but it'd fit more naturally as a subclass of "Salmon productivity". I also notice we don't have any terms about productivity.

@amoeba amoeba added the salmon data Open salmon data mobilization project label Sep 16, 2021
@amoeba amoeba self-assigned this Sep 16, 2021
@mpsaloha
Copy link
Collaborator

This is an area I haven't yet reviewed, and need to do so

@amoeba
Copy link
Collaborator Author

amoeba commented Sep 16, 2021

Thanks @mpsaloha, I'll be curious to hear your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
salmon data Open salmon data mobilization project
Projects
None yet
Development

No branches or pull requests

2 participants