Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more input type warnings #25

Open
atn38 opened this issue Apr 16, 2021 · 2 comments
Open

more input type warnings #25

atn38 opened this issue Apr 16, 2021 · 2 comments
Milestone

Comments

@atn38
Copy link

atn38 commented Apr 16, 2021

Minor issue: when I accidentally gave citation_search a data.frame as input, it gave this non informative error

Error in curl::curl_fetch_memory(x$url$url, handle = x$url$handle) : 
  URL using bad/illegal format or missing URL

Should be fairly trivial to type check inputs and give appropriate warnings IMO

@mbjones
Copy link
Member

mbjones commented Apr 16, 2021

Thanks @atn38 for the feedback, and yeah I agree. We'd welcome a pull request if you had interest in this improvement. If not, we'll try to incorporate this the next time we have cycles to tackle the package.

@mbjones mbjones added this to the 1.0.0 milestone Apr 16, 2021
@jeanetteclark
Copy link
Collaborator

I went ahead and added a very simple warning in the main function which I think accomplishes this, though we could make it more robust. Commit abdbd8c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants