Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambari metrics integration assumes that all metrics are floating point numbers, resulting in dropping of 100s of metrics #18319

Open
meyarivan opened this issue Aug 13, 2024 · 0 comments

Comments

@meyarivan
Copy link

meyarivan commented Aug 13, 2024

Note: If you have a feature request, you should contact support so the request can be properly tracked.

Output of the info page

Agent (v7.53.0)
....

Additional environment details (Operating System, Cloud provider, etc):

Steps to reproduce the issue:

  1. Set up integration with Ambari
  2. Enable collection of metrics for component services such as HDFS and YARN
  3. Check the output of "datadog-agent status" for the metrics that are being ignored

Describe the results you received:

datadog-agent status output is full of messages of the following form:

Warning: Expected a float for rpc.callQueueLen, received 0
Warning: Expected a float for rpc.SentBytes, received 10169111223
....

Describe the results you expected:

Additional information you deem important (e.g. issue happens only occasionally):

IIUC this is the offending line : https://github.com/DataDog/integrations-core/blob/master/ambari/datadog_checks/ambari/ambari.py#L101. It could be if isinstance(value, (float, int)): instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant