Skip to content

Commit 05fc099

Browse files
mwdd146980claude
andcommitted
Revert rename: mock_http_client → mock_http
The fixture name mock_http_client was added in the previous commit, but the team prefers the shorter mock_http name. Revert all usages across integrations and the fixture definition in http_testing.py. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent e5f5345 commit 05fc099

12 files changed

Lines changed: 26 additions & 26 deletions

File tree

couchbase/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import pytest
1111
import requests
1212

13-
from datadog_checks.base.utils.http_testing import MockHTTPResponse, mock_http_client # noqa: F401
13+
from datadog_checks.base.utils.http_testing import MockHTTPResponse, mock_http # noqa: F401
1414
from datadog_checks.couchbase import Couchbase
1515
from datadog_checks.dev import WaitFor, docker_run
1616
from datadog_checks.dev.docker import get_container_ip

couchbase/tests/test_unit.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,8 @@ def test_extract_index_tags(instance, test_input, expected_tags):
124124
assert eval(str(test_output)) == expected_tags
125125

126126

127-
def test_unit(dd_run_check, check, instance, mock_http_client, aggregator):
128-
mock_http_client.get.side_effect = mock_http_responses
127+
def test_unit(dd_run_check, check, instance, mock_http, aggregator):
128+
mock_http.get.side_effect = mock_http_responses
129129

130130
dd_run_check(check(instance))
131131

@@ -140,8 +140,8 @@ def test_unit(dd_run_check, check, instance, mock_http_client, aggregator):
140140
aggregator.assert_metrics_using_metadata(get_metadata_metrics())
141141

142142

143-
def test_unit_query_metrics(dd_run_check, check, instance_query, mock_http_client, aggregator):
144-
mock_http_client.get.side_effect = mock_http_responses
143+
def test_unit_query_metrics(dd_run_check, check, instance_query, mock_http, aggregator):
144+
mock_http.get.side_effect = mock_http_responses
145145

146146
dd_run_check(check(instance_query))
147147

datadog_checks_base/datadog_checks/base/utils/http_testing.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88

99
import pytest
1010

11-
__all__ = ['MockHTTPResponse', 'mock_http_client']
11+
__all__ = ['MockHTTPResponse', 'mock_http']
1212

1313

1414
@pytest.fixture
15-
def mock_http_client(mocker):
15+
def mock_http(mocker):
1616
"""Intercept HTTP calls made through RequestsWrapper; import into integration conftest.py to use.
1717
1818
Patches get/post/put/delete/head/patch at the RequestsWrapper class level so all three

datadog_checks_base/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import pytest
44
import requests
55

6-
from datadog_checks.base.utils.http_testing import mock_http_client # noqa: F401
6+
from datadog_checks.base.utils.http_testing import mock_http # noqa: F401
77
from datadog_checks.base.utils.platform import Platform
88
from datadog_checks.dev import TempDir, docker_run, get_here
99
from datadog_checks.dev.conditions import CheckDockerLogs, WaitFor

falco/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import pytest
77

8-
from datadog_checks.base.utils.http_testing import mock_http_client # noqa: F401
8+
from datadog_checks.base.utils.http_testing import mock_http # noqa: F401
99
from datadog_checks.dev import docker_run
1010
from datadog_checks.dev.conditions import CheckEndpoints
1111

falco/tests/test_unit.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ def test_empty_instance(dd_run_check):
2020
dd_run_check(check)
2121

2222

23-
def test_check_falco(dd_run_check, aggregator, instance, mock_http_client):
24-
mock_http_client.get.side_effect = [
23+
def test_check_falco(dd_run_check, aggregator, instance, mock_http):
24+
mock_http.get.side_effect = [
2525
MockHTTPResponse(file_path=get_fixture_path("falco_metrics.txt")),
2626
]
2727
dd_run_check(FalcoCheck('falco', {}, [instance]))

ray/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import pytest
1111
import requests
1212

13-
from datadog_checks.base.utils.http_testing import mock_http_client # noqa: F401
13+
from datadog_checks.base.utils.http_testing import mock_http # noqa: F401
1414
from datadog_checks.dev import EnvVars, TempDir, docker_run
1515
from datadog_checks.dev._env import get_state, save_state
1616
from datadog_checks.dev.conditions import CheckEndpoints, WaitFor

ray/tests/test_unit.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
pytest.param(MOCKED_WORKER_INSTANCE, WORKER_METRICS, id='worker'),
1717
],
1818
)
19-
def test_check(dd_run_check, aggregator, mock_http_client, check, instance, metrics):
20-
mock_http_client.get.side_effect = mock_http_responses
19+
def test_check(dd_run_check, aggregator, mock_http, check, instance, metrics):
20+
mock_http.get.side_effect = mock_http_responses
2121
dd_run_check(check(instance))
2222

2323
for expected_metric in metrics:
@@ -30,10 +30,10 @@ def test_check(dd_run_check, aggregator, mock_http_client, check, instance, metr
3030
assert len(aggregator.service_check_names) == 1
3131

3232

33-
def test_invalid_url(dd_run_check, aggregator, check, mocked_head_instance, mock_http_client):
33+
def test_invalid_url(dd_run_check, aggregator, check, mocked_head_instance, mock_http):
3434
mocked_head_instance["openmetrics_endpoint"] = "http://unknowwn"
3535

36-
mock_http_client.get.side_effect = mock_http_responses
36+
mock_http.get.side_effect = mock_http_responses
3737
with pytest.raises(Exception):
3838
dd_run_check(check(mocked_head_instance))
3939

strimzi/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import pytest
1010

11-
from datadog_checks.base.utils.http_testing import MockHTTPResponse, mock_http_client # noqa: F401
11+
from datadog_checks.base.utils.http_testing import MockHTTPResponse, mock_http # noqa: F401
1212
from datadog_checks.dev import run_command
1313
from datadog_checks.dev.kind import kind_run
1414
from datadog_checks.dev.kube_port_forward import port_forward

strimzi/tests/test_unit.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@ def test_check_unique_operator(
5454
instance,
5555
metrics,
5656
tag,
57-
mock_http_client,
57+
mock_http,
5858
):
59-
mock_http_client.get.side_effect = mock_http_responses
59+
mock_http.get.side_effect = mock_http_responses
6060
dd_run_check(check(instance))
6161

6262
for expected_metric in metrics:
@@ -75,8 +75,8 @@ def test_check_unique_operator(
7575
assert len(aggregator.service_check_names) == 1
7676

7777

78-
def test_check_all_operators(dd_run_check, aggregator, check, mock_http_client):
79-
mock_http_client.get.side_effect = mock_http_responses
78+
def test_check_all_operators(dd_run_check, aggregator, check, mock_http):
79+
mock_http.get.side_effect = mock_http_responses
8080
dd_run_check(
8181
check(
8282
{

0 commit comments

Comments
 (0)