Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make containerExclude a newline-separated list #1464

Open
der-eismann opened this issue Jul 23, 2024 · 0 comments
Open

Make containerExclude a newline-separated list #1464

der-eismann opened this issue Jul 23, 2024 · 0 comments
Labels
chart/datadog This issue or pull request is related to the datadog chart

Comments

@der-eismann
Copy link

Describe what happened:
We are trying to exclude all daemonset images in DataDog, since their metrics cost too much and don't bring any value to us. That causes the containerExclude line in values.yaml to be 1.300 chars long, completely losing all overview about the entries.

Describe what you expected:
It would be much easier to declare the list newline-separated like

  containerExclude: |
    image:074509403805.dkr.ecr.eu-west-1.amazonaws.com/docker/prom/node-exporter
    image:602401143452.dkr.ecr.eu-west-1.amazonaws.com/amazon-k8s-cni
    image:602401143452.dkr.ecr.eu-west-1.amazonaws.com/amazon/aws-network-policy-agent
    image:602401143452.dkr.ecr.eu-west-1.amazonaws.com/eks/aws-ebs-csi-driver
    image:602401143452.dkr.ecr.eu-west-1.amazonaws.com/eks/aws-efs-csi-driver
    image:602401143452.dkr.ecr.eu-west-1.amazonaws.com/eks/csi-node-driver-registrar
    image:602401143452.dkr.ecr.eu-west-1.amazonaws.com/eks/kube-proxy
    image:602401143452.dkr.ecr.eu-west-1.amazonaws.com/eks/livenessprobe

I'm sure there's a Helm template function for this 🙂

@levan-m levan-m added the chart/datadog This issue or pull request is related to the datadog chart label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart
Projects
None yet
Development

No branches or pull requests

2 participants