Skip to content

Conversation

@vpellan
Copy link
Contributor

@vpellan vpellan commented Oct 22, 2025

⚠️ DO NOT MERGE ⚠️

@github-actions
Copy link

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-10-22 11:28:33 UTC

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Oct 22, 2025
@github-actions
Copy link

github-actions bot commented Oct 22, 2025

Typing analysis

Ignored files

This PR introduces 3 ignored files. It increases the percentage of typed files from 38.31% to 38.6% (+0.29%).

Ignored files (+3-0)Introduced:
lib/datadog/tracing/contrib/karafka/framework.rb
lib/datadog/tracing/contrib/waterdrop/producer.rb
lib/datadog/tracing/contrib/waterdrop/middleware.rb

Note: Ignored files are excluded from the next sections.

Untyped methods

This PR introduces 2 untyped methods and 4 partially typed methods. It decreases the percentage of typed methods from 54.7% to 54.67% (-0.03%).

Untyped methods (+2-0)Introduced:
sig/datadog/tracing/contrib/waterdrop/integration.rbs:12
└── def self.version: () -> untyped
sig/datadog/tracing/contrib/waterdrop/integration.rbs:20
└── def patcher: () -> untyped
Partially typed methods (+4-0)Introduced:
sig/datadog/tracing/contrib/waterdrop/configuration/settings.rbs:7
└── def self.option: (Symbol name, ?untyped meta) ?{ (untyped) -> void } -> untyped
sig/datadog/tracing/contrib/waterdrop/integration.rbs:10
└── def self.register_as: (untyped name, ?registry: untyped, ?auto_patch: bool, **untyped options) -> untyped
sig/datadog/tracing/contrib/waterdrop.rbs:6
└── def self.inject: (Tracing::TraceDigest digest, ::Hash[untyped, untyped] data) -> void
sig/datadog/tracing/contrib/waterdrop.rbs:9
└── def self.extract: (::Hash[untyped, untyped] data) -> Tracing::TraceDigest?

If you believe a method or an attribute is rightfully untyped or partially typed, you can add # untyped:accept to the end of the line to remove it from the stats.

@datadog-official
Copy link

datadog-official bot commented Oct 22, 2025

🎯 Code Coverage
Patch Coverage: 97.16%
Total Coverage: 98.51% (+0.12%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: afdfdbc | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 22, 2025

Benchmarks

Benchmark execution time: 2025-11-13 18:16:09

Comparing candidate commit afdfdbc in PR branch community/pr-4874 with baseline commit 3b63de8 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

scenario:profiling - intern_all 1000 repeated strings

  • 🟥 throughput [-1810.128op/s; -1744.037op/s] or [-6.734%; -6.488%]

@github-actions github-actions bot added the core Involves Datadog core libraries label Nov 4, 2025
@ericfirth ericfirth force-pushed the community/pr-4874 branch 6 times, most recently from 3ea98d3 to 5283ac0 Compare November 6, 2025 15:02
@github-actions github-actions bot added the appsec Application Security monitoring product label Nov 13, 2025
@ericfirth ericfirth force-pushed the community/pr-4874 branch 2 times, most recently from 40aeef8 to af5c93a Compare November 13, 2025 15:29
@ericfirth ericfirth force-pushed the community/pr-4874 branch 2 times, most recently from fb8881f to afdfdbc Compare November 13, 2025 17:45
@ericfirth ericfirth merged commit 49cee89 into master Nov 13, 2025
1884 of 1970 checks passed
@ericfirth ericfirth deleted the community/pr-4874 branch November 13, 2025 20:32
@github-actions github-actions bot added this to the 2.23.0 milestone Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product core Involves Datadog core libraries integrations Involves tracing integrations tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants