-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libddwaf to 1.18.0.0.0 #4164
Conversation
83c82c1
to
e21459e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Left two "just-in-case-check/questions", otherwise it LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4164 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 1353 1353
Lines 81817 81820 +3
Branches 4145 4145
=======================================
+ Hits 80001 80009 +8
+ Misses 1816 1811 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👏🏼
Libddwaf 1.18.0.0.0 had some breaking changes -
actions
in the result is now an array of objects, instead of an array of strings.Please don't merge until 2.8.0 is released
What does this PR do?
This PR updates
libddwaf
dependency to 1.18.0.0.0 and fixes specs that were broken with this update.Motivation:
This version of
libddwaf
is required for detecting SQL injections.Change log entry
None
Additional Notes:
None
How to test the change?
CI is enough