Fix tests after rebase

Author: Strech

lib/datadog/open_feature/exposures/deduplicator.rb

@@ -21,7 +21,7 @@ def duplicate?(event)
           stored = @cache[cache_key]
           return true if stored == cache_digest
 
-          @mutex.synchronize { @cache.store(cache_key, cache_digest) }
+          @mutex.synchronize { @cache[cache_key] = cache_digest }
           false
         end
 

spec/datadog/open_feature/evaluation_engine_spec.rb

@@ -45,7 +45,11 @@
     let(:result) { engine.fetch_value(flag_key: 'test', expected_type: :string) }
 
     context 'when binding evaluator is not ready' do
-      it 'returns evaluation error' do
+      it 'returns evaluation error and reports exposure' do
+        expect(reporter).to receive(:report).with(
+          kind_of(Datadog::OpenFeature::Binding::ResolutionDetails), flag_key: 'test', context: nil
+        )
+
         expect(result.error_code).to eq('PROVIDER_NOT_READY')
         expect(result.error_message).to eq('Waiting for universal flag configuration')
         expect(result.reason).to eq('INITIALIZING')
@@ -72,7 +76,9 @@
         )
       end
 
-      it 'returns evaluation error' do
+      it 'returns evaluation error and reports exposure' do
+        expect(reporter).to receive(:report).with(error, flag_key: 'test', context: nil)
+
         expect(result.error_code).to eq('PROVIDER_FATAL')
         expect(result.error_message).to eq('Ooops')
         expect(result.reason).to eq('ERROR')
@@ -91,7 +97,9 @@
 
       let(:error) { RuntimeError.new("Crash") }
 
-      it 'returns evaluation error' do
+      it 'returns evaluation error and does not report exposure' do
+        expect(reporter).not_to receive(:report)
+
         expect(result.error_code).to eq('PROVIDER_FATAL')
         expect(result.error_message).to eq('Crash')
         expect(result.reason).to eq('ERROR')
@@ -106,7 +114,9 @@
 
       let(:result) { engine.fetch_value(flag_key: 'test', expected_type: :whatever) }
 
-      it 'returns evaluation error' do
+      it 'returns evaluation error and does not report exposure' do
+        expect(reporter).not_to receive(:report)
+
         expect(result.error_code).to eq('UNKNOWN_TYPE')
         expect(result.error_message).to start_with('unknown type :whatever, allowed types')
         expect(result.reason).to eq('ERROR')
@@ -119,9 +129,13 @@
         engine.reconfigure!
       end
 
-      let(:result) { engine.fetch_value(flag_key: 'test', expected_type: :string) }
+      let(:evaluation_context) { instance_double('OpenFeature::SDK::EvaluationContext') }
+      let(:result) { engine.fetch_value(flag_key: 'test', expected_type: :string, evaluation_context: evaluation_context) }
+
+      it 'returns resolved value and reports exposure' do
+        expect(reporter).to receive(:report)
+          .with(kind_of(Datadog::OpenFeature::Binding::ResolutionDetails), flag_key: 'test', context: evaluation_context)
 
-      it 'returns resolved value' do
         expect(result.value).to eq('hello')
       end
     end
@@ -158,6 +172,7 @@
       it 'persists previouly configured evaluator' do
         allow(logger).to receive(:error)
         allow(telemetry).to receive(:report)
+        allow(reporter).to receive(:report)
 
         engine.configuration = '{}'
         expect { engine.reconfigure! }.not_to change {

spec/datadog/open_feature/provider_spec.rb

@@ -7,6 +7,7 @@
 RSpec.describe Datadog::OpenFeature::Provider do
   before do
     allow(telemetry).to receive(:report)
+    allow(reporter).to receive(:report)
     allow(Datadog::OpenFeature).to receive(:engine).and_return(engine)
   end