Skip to content

Commit

Permalink
Merge pull request #4162 from DataDog/ivoanjo/fix-suppresions-after-p…
Browse files Browse the repository at this point in the history
…r-4161

[PROF-10967] Fix missing suppressions after PR 4161 got merged
  • Loading branch information
ivoanjo authored and TonyCTHsu committed Nov 28, 2024
1 parent 550b57e commit 70116bf
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/test-memory-leaks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
bundler: latest
cache-version: v1 # bump this to invalidate cache
- run: sudo apt-get update && (sudo apt-get install -y valgrind || sleep 5 && sudo apt-get install -y valgrind) && valgrind --version
- run: gem update --system 3.5.23 # TODO: This is a workaround for a buggy rubygems in 3.4.0-preview2; remove once stable version 3.4 is out
- run: bundle exec rake compile spec:profiling:memcheck
test-asan:
runs-on: ubuntu-24.04
Expand Down
15 changes: 15 additions & 0 deletions suppressions/ruby-3.4.supp
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,21 @@
...
}

# When a Ruby process forks, it looks like Ruby doesn't clean up the memory of old threads?
{
ruby-native-thread-memory-3
Memcheck:Leak
fun:calloc
fun:calloc1
fun:rb_gc_impl_calloc
fun:ruby_xcalloc
fun:native_thread_alloc
fun:native_thread_create_dedicated
fun:native_thread_create
fun:thread_create_core
...
}

# We don't care about the pkg-config external tool
{
pkg-config-memory
Expand Down

0 comments on commit 70116bf

Please sign in to comment.