Skip to content

Commit 2cc8441

Browse files
committed
Fix CI failures
1 parent 23c59fb commit 2cc8441

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+1449
-15
lines changed

Matrixfile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,11 @@
127127
# karafka 2.0.41 contains broken dependency of karafka-core 2.2.4, which depends on Ruby (>= 2.6.0)
128128
'karafka-min' => '❌ 2.5 / ❌ 2.6 / ❌ 2.7 / ✅ 3.0 / ✅ 3.1 / ✅ 3.2 / ✅ 3.3 / ✅ 3.4 / ✅ 3.5 / ✅ jruby',
129129
},
130+
'waterdrop' => {
131+
# WaterDrop 2.8.8+ requires Ruby >= 3.1.0 (JRuby 9.4+ only, not 9.2/9.3)
132+
'waterdrop-latest' => '❌ 2.5 / ❌ 2.6 / ❌ 2.7 / ❌ 3.0 / ✅ 3.1 / ✅ 3.2 / ✅ 3.3 / ✅ 3.4 / ✅ 3.5 / ✅ jruby-9.4+',
133+
'waterdrop-min' => '❌ 2.5 / ❌ 2.6 / ❌ 2.7 / ❌ 3.0 / ✅ 3.1 / ✅ 3.2 / ✅ 3.3 / ✅ 3.4 / ✅ 3.5 / ✅ jruby-9.4+'
134+
},
130135
'lograge' => {
131136
'activesupport' => '✅ 2.5 / ✅ 2.6 / ✅ 2.7 / ✅ 3.0 / ✅ 3.1 / ✅ 3.2 / ✅ 3.3 / ✅ 3.4 / ✅ 3.5 / ✅ jruby'
132137
},

Rakefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,8 @@ namespace :spec do
286286
:stripe,
287287
:sucker_punch,
288288
:suite,
289-
:trilogy
289+
:trilogy,
290+
:waterdrop
290291
].each do |contrib|
291292
desc '' # "Explicitly hiding from `rake -T`"
292293
RSpec::Core::RakeTask.new(contrib) do |t, args|

Steepfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -329,9 +329,12 @@ target :datadog do
329329
ignore 'lib/datadog/tracing/contrib/karafka/configuration/settings.rb'
330330
ignore 'lib/datadog/tracing/contrib/karafka/distributed/propagation.rb'
331331
ignore 'lib/datadog/tracing/contrib/karafka/ext.rb'
332+
ignore 'lib/datadog/tracing/contrib/karafka/framework.rb'
332333
ignore 'lib/datadog/tracing/contrib/karafka/integration.rb'
333334
ignore 'lib/datadog/tracing/contrib/karafka/monitor.rb'
334335
ignore 'lib/datadog/tracing/contrib/karafka/patcher.rb'
336+
ignore 'lib/datadog/tracing/contrib/waterdrop.rb'
337+
ignore 'lib/datadog/tracing/contrib/waterdrop/'
335338
ignore 'lib/datadog/tracing/contrib/patcher.rb'
336339
ignore 'lib/datadog/tracing/contrib/configuration/resolver.rb'
337340
ignore 'lib/datadog/tracing/contrib/propagation/sql_comment/comment.rb'

appraisal/jruby-10.0.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@
8383
build_coverage_matrix('rest-client')
8484
build_coverage_matrix('dalli', [2])
8585
build_coverage_matrix('karafka', min: '2.3.0')
86+
build_coverage_matrix('waterdrop', min: '2.8.8.rc1')
8687

8788
appraise 'karafka-min' do
8889
gem 'karafka', '= 2.3.0'

appraisal/jruby-9.2.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@
204204
build_coverage_matrix('rest-client')
205205
build_coverage_matrix('mongo', min: '2.1.0')
206206
build_coverage_matrix('dalli', [2])
207+
# NOTE: waterdrop requires Ruby >= 3.1.0, JRuby 9.2 (Ruby 2.5) is not supported
207208
# NOTE: JRuby bundler failed to install some dependencies https://github.com/ruby/psych/issues/700
208209
# and it could be re-enabled when upstream fix the issue
209210
# build_coverage_matrix('devise', min: '3.2.1')

appraisal/jruby-9.3.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@
177177
build_coverage_matrix('rest-client')
178178
build_coverage_matrix('mongo', min: '2.1.0')
179179
build_coverage_matrix('dalli', [2])
180+
# NOTE: waterdrop requires Ruby >= 3.1.0, JRuby 9.3 (Ruby 2.6) is not supported
180181
# NOTE: JRuby bundler failed to install some dependencies https://github.com/ruby/psych/issues/700
181182
# and it could be re-enabled when upstream fix the issue
182183
# build_coverage_matrix('devise', min: '3.2.1')

appraisal/ruby-3.0.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@
9898
build_coverage_matrix('mongo', min: '2.1.0')
9999
build_coverage_matrix('dalli', [2])
100100
build_coverage_matrix('karafka', min: '2.3.0')
101-
build_coverage_matrix('waterdrop', min: '2.8.8.rc1')
102101
build_coverage_matrix('devise', min: '3.2.1')
103102

104103
appraise 'relational_db' do

appraisal/ruby-3.5.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@
9393
build_coverage_matrix('mongo', min: '2.20.0')
9494
build_coverage_matrix('dalli', [2])
9595
build_coverage_matrix('karafka', min: '2.3.0')
96+
build_coverage_matrix('waterdrop', min: '2.8.8.rc1')
9697
build_coverage_matrix('devise', min: '3.2.1')
9798

9899
appraise 'relational_db' do

gemfiles/jruby_10.0_waterdrop_latest.gemfile

Lines changed: 37 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_10.0_waterdrop_latest.gemfile.lock

Lines changed: 137 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)