return in finally swallows exceptions

[iritkatriel]

In

dd-trace-py/benchmarks/bm/_scenario.py

Line 72 in 51fe517

return dt # noqa: B012

there is a return statement in a finally clause, which would swallow any in-flight exception.

Since except StopIteration two lines above explicitly swallows StopIteration exceptions, my guess is that the intention was not to also swallow all other exceptions. If it was, the code could be rewritten to make this clearer.

Similarly, in

dd-trace-py/ddtrace/appsec/_iast/_taint_utils.py

Line 141 in 51fe517

return main_res[0] if main_res else main_obj

there is a return that would swallow any BaseException (including KeyboardInterrupt) where the except only explicitly swallows Exceptions.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.