Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup function throws The "options.lookup" property must be of type function. Received type string in 4.49.0 #4894

Open
blemoine opened this issue Nov 15, 2024 · 0 comments · May be fixed by #4901

Comments

@blemoine
Copy link

blemoine commented Nov 15, 2024

I recently migrated from dd-trace 4.29 to 4.49
I'm using node 22.11.0.

This code:

const ddtrace = require('dd-trace');
const dns = require("node:dns");
const tracer = ddtrace.init({
    serviceName: 'my-service',
    lookup: (...args) => {
        console.log('LOOKUP CALLED');
        return dns.lookup(...args)
    },
    hostname: 'whaafldjslkfds.com',

});


function main() {
    tracer.trace('trace', () => {
            console.log(`TRACED`);
        }
    );
    setTimeout(() => {
        console.log('Time to send the request to the agent')
    }, 2000)
}

main();

Is working and displaying LOOKUP CALLED in 4.29.0, but is throwing
TypeError [ERR_INVALID_ARG_TYPE]: The "options.lookup" property must be of type function. Received type string ('(...args) => {

In 4.49.0

If I should guess the culprit, I'd say this line: lookup is not a string, it's a function.

Edit:
confirming that replacing the above line by this._setValue(opts, 'lookup', options.lookup) solves the problem

blemoine added a commit to blemoine/dd-trace-js that referenced this issue Nov 18, 2024
The previous version was transforming the lookup
parameter to a string.

Closes DataDog#4894
@blemoine blemoine linked a pull request Nov 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant