Need to re-initialize the sdk when versionSuffix changes

[diegodorado]

Feature description

When a user downloads an OTA update (a jsbundle), we do not fully restart the app (as it would be way slower).
We instead call the native side for a js bundle reload.

The issue we are facing is that the datadog initialize method, because already initialized when the app started, will skip the call to initialize after bundle js swap.

To clarify the process, this is happening:

1. App starts
2. jsbundle#111 is loaded
3. datadog initialize is called with versionSuffix=111
4. then, an OTA update is received
5. jsbundle#112 is loaded (without a native app restart)
6. datadog initialize is called with versionSuffix=112

that last call gets omitted... and the sdk interface does not offer any method to re initialize.

I was about to make a patch for the js side of the library, but it looks like it is a bit more involved, as the swift/kotlin implementations are also prepared for a single time initialization.

Is there a workaround for this?
Thanks

Proposed solution

No response

Other relevant information

No response

[cdn34dd]

Hey @diegodorado thanks for reaching out and sorry for the delayed response. This is as you've mentioned not possible unfortunately, but I do see the value in having it behave as you describe. I'll discuss this with the team and get back to you soon. I'll keep the issue open until then.

[sbarrio]

Hello again @diegodorado.

Being able to stop the native SDK instance and reinitialize it again from React Native with a new configuration (such as the versionSuffix) is something that we are working on at the moment to be part of v3 of the SDK.

Please keep an eye on the repository for future news on this feature.

[diegodorado]

Happy to hear that. FYI, this is the patch I currently have on our project:

diff --git a/android/src/main/kotlin/com/datadog/reactnative/DatadogSDKWrapper.kt b/android/src/main/kotlin/com/datadog/reactnative/DatadogSDKWrapper.kt
index c9865a5d7f5bd1f01bf5fc18338e4f16f5366836..5e69f5cb26b6868689ae9d75740721824dbfe88b 100644
--- a/android/src/main/kotlin/com/datadog/reactnative/DatadogSDKWrapper.kt
+++ b/android/src/main/kotlin/com/datadog/reactnative/DatadogSDKWrapper.kt
@@ -108,6 +108,11 @@ internal class DatadogSDKWrapper : DatadogWrapper {
         configuration: Configuration,
         consent: TrackingConsent
     ) {
+        // HACK: until this gets fixed: https://github.com/DataDog/dd-sdk-reactnative/issues/850
+        if(Datadog.isInitialized()){
+          Datadog.stopInstance()
+        }
+
         val core = Datadog.initialize(context, configuration, consent)
         DatadogSDKWrapperStorage.setSdkCore(core as InternalSdkCore)
         DatadogSDKWrapperStorage.notifyOnInitializedListeners(core)
diff --git a/ios/Sources/DatadogSDKWrapper.swift b/ios/Sources/DatadogSDKWrapper.swift
index 842ee5d8904a212d37b70a573f4571e92a788964..0e96fb81490e3a60626347206d1bf60965ce74ae 100644
--- a/ios/Sources/DatadogSDKWrapper.swift
+++ b/ios/Sources/DatadogSDKWrapper.swift
@@ -49,6 +49,11 @@ public class DatadogSDKWrapper {
         loggerConfiguration: DatadogLogs.Logger.Configuration,
         trackingConsent: TrackingConsent
     ) -> Void {
+        // HACK: until this gets fixed: https://github.com/DataDog/dd-sdk-reactnative/issues/850
+        if Datadog.isInitialized() {
+          Datadog.stopInstance()
+        }
+
         let core = Datadog.initialize(with: coreConfiguration, trackingConsent: trackingConsent)
         setCoreInstance(core: core)
         for listener in onCoreInitializedListeners {
diff --git a/ios/Sources/DdSdkNativeInitialization.swift b/ios/Sources/DdSdkNativeInitialization.swift
index d68d89d069d266a86f0015727a200e3cb3f36c8a..2e28cd9cef4afadd1d58539f3ca0618d31c075e9 100644
--- a/ios/Sources/DdSdkNativeInitialization.swift
+++ b/ios/Sources/DdSdkNativeInitialization.swift
@@ -30,20 +30,6 @@ public class DdSdkNativeInitialization: NSObject {
     }
     
     internal func initialize(sdkConfiguration: DdSdkConfiguration) {
-        // TODO: see if this `if` is still needed
-        if DatadogSDKWrapper.shared.isInitialized() {
-            // Initializing the SDK twice results in Global.rum and
-            // Global.sharedTracer to be set to no-op instances
-            consolePrint("Datadog SDK is already initialized, skipping initialization.", .debug)
-            DatadogSDKWrapper.shared.telemetryDebug(id: "datadog_react_native: RN  SDK was already initialized in native", message: "RN SDK was already initialized in native")
-
-            RUMMonitor.shared().currentSessionID { sessionId in
-                guard let id = sessionId else { return }
-                DdSdkSessionStartedListener.instance.rumSessionListener?(id, false)
-            }
-
-            return
-        }
         self.setVerbosityLevel(configuration: sdkConfiguration)
 
         let coreConfiguration = self.buildSDKConfiguration(configuration: sdkConfiguration)
diff --git a/src/DdSdkReactNative.tsx b/src/DdSdkReactNative.tsx
index aa7e2ec364ae2ee643a053222bcc05c943ed4954..c4079bfe05e705b734fbdcd750f4913e72a415fd 100644
--- a/src/DdSdkReactNative.tsx
+++ b/src/DdSdkReactNative.tsx
@@ -72,24 +72,12 @@ export class DdSdkReactNative {
         DdSdkReactNative.enableFeatures(configuration);
     };
 
-    private static initializeNativeSDK = async (
+    static initializeNativeSDK = async (
         configuration: DdSdkReactNativeConfiguration,
         params: {
             initializationModeForTelemetry: InitializationModeForTelemetry;
         }
     ): Promise<void> => {
-        if (GlobalState.instance.isInitialized) {
-            InternalLog.log(
-                "Can't initialize Datadog, SDK was already initialized",
-                SdkVerbosity.WARN
-            );
-            if (!__DEV__) {
-                DdSdk.telemetryDebug(
-                    'RN SDK was already initialized in javascript'
-                );
-            }
-            return new Promise(resolve => resolve());
-        }
 
         InternalLog.verbosity = configuration.verbosity;
 
@@ -371,14 +359,6 @@ export class DdSdkReactNative {
             DdBabelInteractionTracking.getInstance(DdRum);
         }
 
-        if (DdSdkReactNative.wasAutoInstrumented) {
-            InternalLog.log(
-                "Can't auto instrument Datadog, SDK was already instrumented",
-                SdkVerbosity.WARN
-            );
-            return;
-        }
-
         if (
             configuration.trackInteractions &&
             !globalThis.__DD_RN_BABEL_PLUGIN_ENABLED__