Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling statsd export via constructor arg #778

Open
tuukkamustonen opened this issue Jun 13, 2023 · 1 comment
Open

Allow disabling statsd export via constructor arg #778

tuukkamustonen opened this issue Jun 13, 2023 · 1 comment
Labels
kind/feature-request Feature request related issue stale Stale - Bot reminder

Comments

@tuukkamustonen
Copy link

tuukkamustonen commented Jun 13, 2023

Is your feature request related to a problem? Please describe.

During development (and sometimes in production) we want to disable the statsd metrics export. The docs state:

In development, you can disable any statsd metric collection using DD_DOGSTATSD_DISABLE=True (or any not-empty value).

Two problems:

  • It's not possible to disable the DogStatsd via constructor
  • The docs are not right, code actually checks the value against a set of {"True", "true", "yes", "1"} values (so not any not-empty value)

Describe the solution you'd like

  • Support disable_export (or with better name) in constructor
  • Fix the docs

Describe alternatives you've considered

Could use a dummy statsd client that implements the DogStatsd API. But I'd rather just disable the export, so the logic gets covered.

Or, it might would be useful if the client did log/console output, instead of completely disabling the export.

Additional context

n/a

@tuukkamustonen tuukkamustonen added the kind/feature-request Feature request related issue label Jun 13, 2023
@github-actions
Copy link

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of this project.

  2. Comment that the issue is still reproducible and include updated details requested in the issue template.

@github-actions github-actions bot added the stale Stale - Bot reminder label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request Feature request related issue stale Stale - Bot reminder
Projects
None yet
Development

No branches or pull requests

1 participant