Skip to content

Conversation

@pgimalac
Copy link
Member

What does this PR do?

Update MultiHandler to only call a inner handler's Handle method if this Handler is enabled.

Motivation

The documentation of the Handle method explicitly says that the method should only be called when enabled.

// Handle handles the Record.
// It will only be called when Enabled returns true.

Describe how you validated your changes

CI

Additional Notes

@pgimalac pgimalac requested a review from a team as a code owner November 28, 2025 09:34
@pgimalac pgimalac requested a review from fabbing November 28, 2025 09:34
@pgimalac pgimalac added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-runtimes labels Nov 28, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 28, 2025
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 716b81c

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+2.06}$$ $${705.37}$$ < $${717.44}$$ $${+0.39}$$ $${172.83}$$ < $${177.37}$$
agent_deb_amd64_fips $${+2.85}$$ $${700.21}$$ < $${711.66}$$ $${+0.73}$$ $${171.74}$$ < $${174.84}$$
agent_heroku_amd64 $${-0.76}$$ $${326.74}$$ < $${337.57}$$ $${-0.15}$$ $${87.25}$$ < $${90.78}$$
agent_msi $${-19.14}$$ $${981.13}$$ < $${1015.38}$$ $${-2.4}$$ $${142.05}$$ < $${149.42}$$
agent_rpm_amd64 $${+2.06}$$ $${705.35}$$ < $${717.41}$$ $${+0.33}$$ $${175.89}$$ < $${178.01}$$
agent_rpm_amd64_fips $${+2.85}$$ $${700.2}$$ < $${711.64}$$ $${+0.7}$$ $${173.98}$$ < $${177.26}$$
agent_rpm_arm64 $${+2.12}$$ $${690.72}$$ < $${702.19}$$ $${+0.51}$$ $${159.76}$$ < $${163.22}$$
agent_rpm_arm64_fips $${+2.82}$$ $${686.59}$$ < $${697.6}$$ $${+0.52}$$ $${159.16}$$ < $${162.68}$$
agent_suse_amd64 $${+2.06}$$ $${705.35}$$ < $${717.41}$$ $${+0.33}$$ $${175.89}$$ < $${178.01}$$
agent_suse_amd64_fips $${+2.85}$$ $${700.2}$$ < $${711.64}$$ $${+0.7}$$ $${173.98}$$ < $${177.26}$$
agent_suse_arm64 $${+2.12}$$ $${690.72}$$ < $${702.19}$$ $${+0.51}$$ $${159.76}$$ < $${163.22}$$
agent_suse_arm64_fips $${+2.82}$$ $${686.59}$$ < $${697.6}$$ $${+0.52}$$ $${159.16}$$ < $${162.68}$$
docker_agent_amd64 $${+2.03}$$ $${767.71}$$ < $${769.92}$$ $${+0.64}$$ $${260.71}$$ < $${261.52}$$
docker_agent_arm64 $${+2.06}$$ $${777.4}$$ < $${779.46}$$ $${+0.58}$$ $${250.9}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${+2.03}$$ $${958.59}$$ < $${960.8}$$ $${+0.63}$$ $${329.35}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${+2.06}$$ $${957.0}$$ < $${958.93}$$ $${+0.58}$$ $${315.52}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${+0.05}$$ $${178.32}$$ < $${207.49}$$ $${+0.01}$$ $${63.0}$$ < $${70.2}$$
docker_cluster_agent_arm64 $${+0.06}$$ $${195.83}$$ < $${223.38}$$ $${+0}$$ $${59.74}$$ < $${66.42}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${+0.03}$$ $${38.57}$$ < $${39.3}$$ $${+0.01}$$ $${14.9}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${-0}$$ $${37.24}$$ < $${37.94}$$ $${+0.01}$$ $${14.35}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${+0.03}$$ $${29.79}$$ < $${30.53}$$ $${+0}$$ $${7.86}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${+0.03}$$ $${28.3}$$ < $${29.11}$$ $${+0}$$ $${6.8}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${+0.03}$$ $${29.79}$$ < $${30.53}$$ $${+0}$$ $${7.87}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${+0.03}$$ $${29.79}$$ < $${30.53}$$ $${+0}$$ $${7.87}$$ < $${8.76}$$
iot_agent_deb_amd64 $${+0.03}$$ $${42.54}$$ < $${43.19}$$ $${+0.01}$$ $${11.11}$$ < $${11.98}$$
iot_agent_deb_arm64 $${+0.02}$$ $${40.28}$$ < $${40.92}$$ $${+0.01}$$ $${9.57}$$ < $${10.45}$$
iot_agent_deb_armhf $${+0.02}$$ $${40.19}$$ < $${40.86}$$ $${+0.01}$$ $${9.68}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${+0.03}$$ $${42.54}$$ < $${43.19}$$ $${+0.01}$$ $${11.13}$$ < $${12.0}$$
iot_agent_suse_amd64 $${+0.03}$$ $${42.54}$$ < $${43.19}$$ $${+0.01}$$ $${11.13}$$ < $${12.0}$$

@cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 55b9bae8-1efc-484d-a709-cff3cb54652f

Baseline: c6a252a
Comparison: f0d9fc1
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.32 [-1.62, +4.27] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.32 [-1.62, +4.27] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.72 [+0.65, +0.79] 1 Logs
ddot_logs memory utilization +0.65 [+0.58, +0.72] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.53 [+0.38, +0.68] 1 Logs
ddot_metrics memory utilization +0.52 [+0.30, +0.74] 1 Logs
otlp_ingest_logs memory utilization +0.48 [+0.39, +0.57] 1 Logs
otlp_ingest_metrics memory utilization +0.36 [+0.22, +0.50] 1 Logs
quality_gate_idle memory utilization +0.30 [+0.24, +0.35] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization +0.23 [+0.03, +0.43] 1 Logs
quality_gate_idle_all_features memory utilization +0.13 [+0.08, +0.18] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.13 [+0.08, +0.18] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.05 [-0.36, +0.46] 1 Logs
file_tree memory utilization +0.04 [-0.00, +0.09] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.08, +0.08] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.13, +0.12] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.38, +0.37] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.06, +0.03] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.03 [-0.16, +0.11] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.04 [-0.40, +0.32] 1 Logs
docker_containers_memory memory utilization -0.10 [-0.18, -0.01] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.24 [-0.48, +0.00] 1 Logs
quality_gate_metrics_logs memory utilization -0.65 [-0.86, -0.45] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -2.55 [-3.99, -1.11] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@pgimalac
Copy link
Member Author

pgimalac commented Dec 1, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 1, 2025

View all feedbacks in Devflow UI.

2025-12-01 14:48:32 UTC ℹ️ Start processing command /merge


2025-12-01 14:48:36 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 42m (p90).


2025-12-01 15:19:22 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit f04393c into main Dec 1, 2025
316 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pgimalac/slog-multi-handler-enabled branch December 1, 2025 15:19
@github-actions github-actions bot added this to the 7.75.0 milestone Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-runtimes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants