Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] broken compatibility because of opentelemetry-mapping-go, can't build my project #33674

Open
rosti-il opened this issue Feb 3, 2025 · 2 comments
Labels

Comments

@rosti-il
Copy link

rosti-il commented Feb 3, 2025

github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes version v0.25.0 broke compatibility with its previous version v0.24.0 and datadog-agent depends on it. After upgrading dependencies by go get -u ./... command in my project that uses datadog-agent it can't be built.

# github.com/DataDog/datadog-agent/pkg/trace/traceutil
../../../go/pkg/mod/github.com/!data!dog/datadog-agent/pkg/[email protected]/traceutil/otel_util.go:413:46: not enough arguments in call to tr.ResourceToSource
        have (context.Context, pcommon.Resource, "go.opentelemetry.io/otel/attribute".Set)
        want (context.Context, pcommon.Resource, "go.opentelemetry.io/otel/attribute".Set, "github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes".HostFromAttributesHandler)
Collapse

both the opentelemetry-mapping-go and datadog-agent are projects of DataDog.

Please do:

  • Fix the datadog-agent.
  • Don't release incompatible versions of dependencies without switching to a newer major release number (for example v0.24.0 ==> v1.0.0 instead v0.24.0 ==> v0.25.0), so go get -u ./... will not bring them.

Temporary workaround is downgrading opentelemetry-mapping-go by running:
go get github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/[email protected]

@github-actions github-actions bot added the team/opentelemetry OpenTelemetry team label Feb 3, 2025
@ogaca-dd
Copy link
Contributor

ogaca-dd commented Feb 3, 2025

Hi,
Sorry for the trouble.
This PR was merged. Rebase from the latest main branch should fix the issue.

@ericfialkowski
Copy link

ericfialkowski commented Feb 4, 2025

Is there a planned date to cut a new release with the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants