Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ [RUM-6813] Use promise in collectAsyncCalls instead of a callback #3168

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Nov 26, 2024

Motivation

Use promise in collectAsyncCalls instead of a callback.
This will also benefit for the replay lazy loading tests: PR

Changes

  • Use promise in collectAsyncCalls instead of a callback.
  • Use the async await syntax in the corresponding tests.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner November 26, 2024 11:10
@amortemousque amortemousque changed the base branch from main to v6 November 26, 2024 11:10
packages/core/test/collectAsyncCalls.ts Outdated Show resolved Hide resolved
Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 152.01 KiB 152.01 KiB 0 B 0.00%
Logs 50.80 KiB 50.80 KiB 0 B 0.00%
Rum Slim 102.21 KiB 102.21 KiB 0 B 0.00%
Worker 25.16 KiB 25.16 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.001 0.001 0.000
addaction 0.031 0.030 -0.001
addtiming 0.001 0.001 -0.000
adderror 0.032 0.029 -0.003
startstopsessionreplayrecording 0.669 0.696 0.027
startview 0.852 0.835 -0.017
logmessage 0.019 0.018 -0.001
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 8.54 KiB 9.26 KiB 742 B
addaction 40.80 KiB 41.31 KiB 523 B
addtiming 7.76 KiB 6.44 KiB -1359 B
adderror 45.58 KiB 42.11 KiB -3551 B
startstopsessionreplayrecording 6.31 KiB 4.34 KiB -2024 B
startview 405.49 KiB 404.21 KiB -1309 B
logmessage 40.40 KiB 40.99 KiB 614 B

🔗 RealWorld

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 93.58%. Comparing base (ff85ce8) to head (7d530e9).
Report is 12 commits behind head on v6.

Files with missing lines Patch % Lines
packages/core/test/collectAsyncCalls.ts 58.82% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #3168      +/-   ##
==========================================
- Coverage   93.61%   93.58%   -0.04%     
==========================================
  Files         279      279              
  Lines        7474     7478       +4     
  Branches     1691     1691              
==========================================
+ Hits         6997     6998       +1     
- Misses        477      480       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amortemousque amortemousque changed the title ✅ Use promise in collectAsyncCalls instead of a callback ✅ [RUM-6813] Use promise in collectAsyncCalls instead of a callback Nov 27, 2024
@amortemousque amortemousque merged commit 221551c into v6 Nov 27, 2024
16 checks passed
@amortemousque amortemousque deleted the aymeric/use-collectAsyncCalls-with-promise branch November 27, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants