Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷‍♀ Enable reduced Session Replay data batch time limit #3088

Merged
merged 1 commit into from
Oct 23, 2024
Merged

👷‍♀ Enable reduced Session Replay data batch time limit #3088

merged 1 commit into from
Oct 23, 2024

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented Oct 23, 2024 •
edited
Loading

Motivation

We can now go for GA to reduce batch time limit

Changes

Remove feature flag

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@RomanGaignault RomanGaignault requested a review from a team as a code owner October 23, 2024 12:40
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.67%. Comparing base (8bd1493) to head (037fb51).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3088      +/-   ##
==========================================
+ Coverage   93.64%   93.67%   +0.03%     
==========================================
  Files         276      276              
  Lines        7628     7624       -4     
  Branches     1712     1710       -2     
==========================================
- Hits         7143     7142       -1     
+ Misses        485      482       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomanGaignault RomanGaignault changed the title Remove feature flag 👷‍♀ Remove feature flag Oct 23, 2024
@cit-pr-commenter cit-pr-commenter
Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.36 KiB 161.23 KiB -133 B -0.08% ✅
Logs 56.07 KiB 56.00 KiB -68 B -0.12% ✅
Rum Slim 109.87 KiB 109.80 KiB -68 B -0.06% ✅
Worker 25.21 KiB 25.21 KiB 0 B 0.00% ✅
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 0.000
addaction 0.034 0.044 0.010
addtiming 0.001 0.001 0.000
adderror 0.040 0.034 -0.005
startstopsessionreplayrecording 0.948 1.201 0.253
startview 1.115 1.305 0.189
logmessage 0.024 0.024 -0.001
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext NaN KiB 8.89 KiB NaN KiB
addaction 39.43 KiB 40.11 KiB 691 B
addtiming 6.96 KiB 8.41 KiB 1.45 KiB
adderror 44.53 KiB 44.62 KiB 93 B
startstopsessionreplayrecording 5.91 KiB 5.80 KiB -108 B
startview 462.13 KiB 469.42 KiB 7.30 KiB
logmessage 38.89 KiB 42.99 KiB 4.09 KiB

🔗 RealWorld

@RomanGaignault RomanGaignault changed the title 👷‍♀ Remove feature flag 👷‍♀ Remove batch time limit feature flag Oct 23, 2024
@RomanGaignault RomanGaignault changed the title 👷‍♀ Remove batch time limit feature flag 👷‍♀ Enable reduced Session Replay data batch time limit Oct 23, 2024
@RomanGaignault RomanGaignault merged commit 42f4d68 into main Oct 23, 2024
19 checks passed
@RomanGaignault RomanGaignault deleted the romanG/remove-ff-batch-time-limit branch October 23, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes

@thomas-lebeau thomas-lebeau thomas-lebeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RomanGaignault @codecov-commenter @BenoitZugmeyer @thomas-lebeau