[FA] Process apm list again (#600)

* Move apm libraries processing

* Debug

* Fix loop condition

* Fix

* Temptative fix

* Temptative fix

* Cleanup

* Fix

* Fix

* Fix

* Fix

* Fix linter

* Fix

* Fix

* Add default loo

* Add default loop

* Fix default value

* Fix default value

* Fix default value

* Fix default value

* Fix default value

* Fix default value

* Fix default value

Author: coignetp

tasks/installer-setup.yml

@@ -86,6 +86,15 @@
     - not datadog_installer_bootstrap_result.failed
   loop: "{{ datadog_installer_owned_apm_packages.results }}"
 
+- name: Update version number for APM libraries not owned by the installer
+  set_fact:
+    pre_processed_datadog_apm_libraries: "{{ pre_processed_datadog_apm_libraries | default([], true) |
+       difference([(item.item | regex_replace('[:]latest', ''))]) }}"
+  loop: "{{ datadog_installer_owned_apm_packages.results }}"
+  when:
+    - item.rc == 0
+    - not datadog_installer_bootstrap_result.failed
+
 - name: Stop duration measurements
   command: "date +%s%N"
   register: datadog_installer_stop_time

tasks/pkg-debian/install-apm-inject.yml

@@ -3,15 +3,16 @@
   set_fact:
     agent_dd_apm_install_pkgs: "{{ (agent_dd_apm_install_pkgs |
       default([], true)) + ['datadog-apm-library-' + (item | regex_replace('[:]', '='))] }}"
-  loop: "{{ pre_processed_datadog_apm_libraries }}"
+  loop: "{{ pre_processed_datadog_apm_libraries | default([], true) }}"
   when: not ansible_check_mode
 
 - name: Unpin tracer libraries for install
   dpkg_selections:
     name: "{{ item }}"
     selection: install
-  loop: "{{ agent_dd_apm_install_pkgs | reject('match', '^.*=.*$') | list }}"
+  loop: "{{ agent_dd_apm_install_pkgs | default([], true) | reject('match', '^.*=.*$') | list }}"
   failed_when: false
+  when: not ansible_check_mode
 
 - name: Install APM Inject Library
   apt:
@@ -25,15 +26,15 @@
   apt:
     name: "{{ (item | default([], true)) }}"
     state: "{{ 'present' if '=' in item else 'latest' }}" # noqa package-latest
-  loop: "{{ agent_dd_apm_install_pkgs }}"
+  loop: "{{ agent_dd_apm_install_pkgs | default([], true) }}"
   when: not ansible_check_mode
 
 - name: Show installed tracers
   debug:
-    msg: "Installed tracers: {{ agent_dd_apm_install_pkgs }}"
+    msg: "Installed tracers: {{ agent_dd_apm_install_pkgs | default([], true) }}"
 
 - name: Prevent libraries from being upgraded
   dpkg_selections:
     name: "{{ item.split('=')[0] }}"
     selection: hold
-  loop: "{{ agent_dd_apm_install_pkgs | select('match', '^.*=.*$') | list }}"
+  loop: "{{ agent_dd_apm_install_pkgs | default([], true) | select('match', '^.*=.*$') | list }}"

tasks/pkg-redhat.yml

@@ -119,7 +119,7 @@
       set_fact:
         agent_dd_apm_install_pkgs: "{{ (agent_dd_apm_install_pkgs |
           default([], true)) + ['datadog-apm-library-' + (item | regex_replace('[:]', '-'))] }}"
-      loop: "{{ pre_processed_datadog_apm_libraries }}"
+      loop: "{{ pre_processed_datadog_apm_libraries | default([], true) }}"
       when: not ansible_check_mode and datadog_apm_instrumentation_enabled | length > 0
 
     - name: Set versioned includepkgs variable

tasks/pkg-redhat/install-apm-inject.yml

@@ -4,7 +4,7 @@
   set_fact:
     agent_dd_apm_install_pkgs: "{{ (agent_dd_apm_install_pkgs |
       default([], true)) + ['datadog-apm-library-' + (item | regex_replace('[:]', '-'))] }}"
-  loop: "{{ pre_processed_datadog_apm_libraries }}"
+  loop: "{{ pre_processed_datadog_apm_libraries  | default([], true) }}"
   when: not ansible_check_mode and ansible_pkg_mgr == "dnf"
 
 - name: Install APM inject library (dnf)

tasks/telemetry.yml

@@ -14,7 +14,7 @@
       "{{ telemetry_payload | default({}) |
           combine({telemetry_library_key[item.split(':')[0]]:
             item.split(':')[1] | default('default')}) }}"
-  loop: "{{ pre_processed_datadog_apm_libraries }}"
+  loop: "{{ pre_processed_datadog_apm_libraries | default([], true) }}"
 
 - name: Build telemetry request
   set_fact:
@@ -27,7 +27,7 @@
         event_name: 'agent.injection.success'
         tags: "{{ {'install_time': ansible_date_time.epoch | int,
                    'install_type': 'ansible'} |
-                   combine(telemetry_payload) }}"
+                   combine(telemetry_payload | default({})) }}"
 
 - name: Send installation telemetry to Datadog
   uri: