chore: fix jsii warnings about naming

Author: rehanvdm

API.md

@@ -3,7 +3,7 @@ import * as chatbot from 'aws-cdk-lib/aws-chatbot';
 import { SlackChannelConfigurationProps } from 'aws-cdk-lib/aws-chatbot/lib/slack-channel-configuration';
 import { Construct } from 'constructs';
 
-export interface SlackChannelId {
+export interface SlackChannel {
   readonly slackChannelConfigurationName: string;
   readonly slackWorkspaceId: string;
   readonly slackChannelId: string;
@@ -12,7 +12,7 @@ export interface SlackChannelId {
 export class AccountChatbots {
   public static slackChatBots: Record<string, chatbot.SlackChannelConfiguration> = {};
 
-  public static existsSlackChannel(scope: Construct, chatbotProps: SlackChannelId): boolean {
+  public static existsSlackChannel(scope: Construct, chatbotProps: SlackChannel): boolean {
     const account = Stack.of(scope).account;
     const chatBotId = AccountChatbots.slackBotId(account, chatbotProps);
     return !!AccountChatbots.slackChatBots[chatBotId];
@@ -28,7 +28,7 @@ export class AccountChatbots {
     return AccountChatbots.slackChatBots[chatBotId];
   }
 
-  public static findSlackChannel(scope: Construct, chatbotProps: SlackChannelId) {
+  public static findSlackChannel(scope: Construct, chatbotProps: SlackChannel) {
     const account = Stack.of(scope).account;
     const chatBotId = AccountChatbots.slackBotId(account, chatbotProps);
 
@@ -37,7 +37,7 @@ export class AccountChatbots {
     return AccountChatbots.slackChatBots[chatBotId];
   }
 
-  private static slackBotId(account: string, chatbotProps: SlackChannelId): string {
+  private static slackBotId(account: string, chatbotProps: SlackChannel): string {
     return [
       account,
       chatbotProps.slackWorkspaceId,

src/constructs/account-chatbots/index.ts

@@ -3,12 +3,12 @@ import * as iam from 'aws-cdk-lib/aws-iam';
 import * as sns from 'aws-cdk-lib/aws-sns';
 import * as subscriptions from 'aws-cdk-lib/aws-sns-subscriptions';
 import { Construct } from 'constructs';
-import { AccountChatbots, SlackChannelId } from '../account-chatbots';
+import { AccountChatbots, SlackChannel } from '../account-chatbots';
 
 
 export interface BudgetSubscribers {
   readonly emails?: string[];
-  readonly slack?: SlackChannelId;
+  readonly slack?: SlackChannel;
 }
 
 export interface BudgetProps {
@@ -19,7 +19,7 @@ export interface BudgetProps {
 }
 
 export class Budget {
-  public readonly budget: budgets.CfnBudget;
+  public readonly cfnBudget: budgets.CfnBudget;
   public readonly notificationTopic: sns.Topic;
 
   constructor(scope: Construct, id: string, props: BudgetProps) {
@@ -47,7 +47,7 @@ export class Budget {
       slackChannel.addNotificationTopic(this.notificationTopic);
     }
 
-    this.budget = new budgets.CfnBudget(scope, id, {
+    this.cfnBudget = new budgets.CfnBudget(scope, id, {
       budget: {
         budgetName: props.name,
         budgetType: 'COST',

src/constructs/budget/index.ts

@@ -1,5 +1,5 @@
 import { App, Stack, Tags } from 'aws-cdk-lib';
-import { BudgetProps, DlzControlTowerStandardControls, DlzStack, SlackChannelId } from './constructs';
+import { BudgetProps, DlzControlTowerStandardControls, DlzStack, SlackChannel } from './constructs';
 import { DlzTag } from './constructs/organization-policies/tag-policy';
 import { Report } from './lib/report';
 import { ManagementStack } from './stacks';
@@ -249,7 +249,7 @@ export interface MandatoryTags {
 
 export interface SecurityHubNotification {
   readonly emails?: string[];
-  readonly slack?: SlackChannelId;
+  readonly slack?: SlackChannel;
 }
 
 export interface SecurityHubNotifications {

src/data-landing-zone.ts

@@ -8,15 +8,15 @@ import {
   DlzAccountType,
   DlzControlTowerStandardControls,
   Region,
-  SlackChannelId,
+  SlackChannel,
 } from '../src';
 // import * as sns from 'aws-cdk-lib/aws-sns';
 
 test('Local build and debug', () => {
   const app = new App();
   // const dlz = new DataLandingZone(app, {
 
-  const slackBudgetNotifications: SlackChannelId = {
+  const slackBudgetNotifications: SlackChannel = {
     slackChannelConfigurationName: 'budget-alerts',
     slackWorkspaceId: 'T1',
     slackChannelId: 'C2',