Skip to content

pfSense & OPNsense: test skipping with ENV ID #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2025
Merged

pfSense & OPNsense: test skipping with ENV ID #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c58d91
pfSense & OPNsense: test skipping with ENV ID
matmacieje Aug 29, 2025
d4485b5
TESTED_BSD_DISTROS variable introduced to default.robot
matmacieje Aug 29, 2025
37f1c0f
TESTED_BSD_DISTROS populated for Protectli platforms.
matmacieje Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions dasharo-compatibility/os-opnsense.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ Resource ../keys.robot
# Log Out And Close Connection - elementary teardown keyword for all tests.
Suite Setup Run Keywords
... Prepare Test Suite
... AND
... Skip If '${ENV_ID_OPNSENSE}' not in ${TESTED_BSD_DISTROS} OPNsense tests not supported
Suite Teardown Run Keywords
... Log Out And Close Connection
Test Setup Run Keyword
... Restore Initial DUT Connection Method

Default Tags semiauto


*** Test Cases ***
OPN001.503 Install operating system on disk (OPNsense)
Expand All @@ -30,6 +30,7 @@ OPN001.503 Install operating system on disk (OPNsense)
... modification.
...
... Previous IDs: OPN001.001
[Tags] semiauto
Power On
Boot OPNsense Installer
VAR ${installer_message}=
Expand All @@ -41,16 +42,13 @@ OPN001.503 Install operating system on disk (OPNsense)

OPN002.503 Boot operating system from disk (OPNsense)
[Documentation] Boot OPNsense (serial output) from disk.
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: OPN001.002
Power On
Boot OPNsense

OPN003.503 Boot operating system from disk after cold-boot (OPNsense)
[Documentation] Boot OPNsense (serial output) from disk after cold-boot
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: BOS001.001
VAR @{supported_power_ctrls}= RteCtrl sonoff
Expand All @@ -64,8 +62,6 @@ OPN003.503 Boot operating system from disk after cold-boot (OPNsense)

OPN004.503 Boot operating system from disk after warm-boot (OPNsense)
[Documentation] Boot OPNsense (serial output) from disk after warm-boot
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: BOS002.001
Power On
Expand All @@ -81,8 +77,6 @@ OPN004.503 Boot operating system from disk after warm-boot (OPNsense)

OPN005.503 Boot operating system from disk after reboot (OPNsense)
[Documentation] Boot OPNsense (serial output) from disk after reboot
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: BOS003.001
Power On
Expand Down
16 changes: 4 additions & 12 deletions dasharo-compatibility/os-pfsense.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,21 @@ Resource ../keys.robot
# Log Out And Close Connection - elementary teardown keyword for all tests.
Suite Setup Run Keywords
... Prepare Test Suite
... AND
... Skip If '${ENV_ID_PFSENSE}' not in ${TESTED_BSD_DISTROS} pfSense tests not supported
Suite Teardown Run Keywords
... Log Out And Close Connection
Test Setup Run Keyword
... Restore Initial DUT Connection Method

Default Tags semiauto


*** Test Cases ***
PFS001.502 Install operating system on disk (pfSense)
[Documentation] Install pfSense LTS CE (serial output) from preseeded
... USB stick on disk. Refer to test case PFS006.502 for preseed.
...
... Previous IDs: PFS001.001
[Tags] semiauto
Power On
Boot PfSense Installer
VAR ${installer_message}=
Expand All @@ -37,17 +38,13 @@ PFS001.502 Install operating system on disk (pfSense)

PFS002.502 Boot operating system from disk (pfSense)
[Documentation] Boot pfSense LTS CE (serial output) from disk.
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: PFS001.002
Power On
Boot PfSense

PFS003.502 Boot operating system from disk after cold-boot (pfSense)
[Documentation] Boot pfSense LTS CE (serial output) from disk after cold-boot
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: BPS001.001
VAR @{supported_power_ctrls}= RteCtrl sonoff
Expand All @@ -61,8 +58,6 @@ PFS003.502 Boot operating system from disk after cold-boot (pfSense)

PFS004.502 Boot operating system from disk after warm-boot (pfSense)
[Documentation] Boot pfSense LTS CE (serial output) from disk after warm-boot
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: BPS002.001
Power On
Expand All @@ -78,8 +73,6 @@ PFS004.502 Boot operating system from disk after warm-boot (pfSense)

PFS005.502 Boot operating system from disk after reboot (pfSense)
[Documentation] Boot pfSense LTS CE (serial output) from disk after reboot
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: BPS003.001
Power On
Expand All @@ -97,6 +90,7 @@ PFS006.502 Preseed operating system installer (pfSense)
... pfSense installer to PFEFI.
... This test depends on semi-manual OS installatio media preparation,
... thus it's marked as semiauto.
[Tags] semiauto
VAR ${pfefi_message}=
... Rename ESP partition of pfSense
... serial installer to PFEFI.\nOn Linux: (sudo) fatlabel /dev/sdX1
Expand Down Expand Up @@ -125,8 +119,6 @@ PFS006.502 Preseed operating system installer (pfSense)

PFS007.502 Boot operating system installer into rescue shell (pfSense)
[Documentation] Boot installer into rescue shell.
... This test depends on semi-manual OS installatio media preparation,
... thus it's marked as semiauto.
Power On
Boot PfSense Installer
Enter PfSense Rescue Shell
Expand Down
1 change: 1 addition & 0 deletions platform-configs/include/default.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,7 @@ ${DCU_SUPPORTED_BOOLEAN_SMMSTORE_VARIABLE}= NetworkBoot
${WINDOWS_SHUTDOWN_AWAITING_SECONDS}= 120

@{TESTED_LINUX_DISTROS}= ${ENV_ID_UBUNTU}
@{TESTED_BSD_DISTROS}= @{EMPTY}
${DEFAULT_BOOT_OS_ID}= ${ENV_ID_UBUNTU}
${BOOTED_OS_ID}= ${DEFAULT_BOOT_OS_ID}

Expand Down
1 change: 1 addition & 0 deletions platform-configs/include/protectli-common.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ ${TESTS_IN_UBUNTU_SUPPORT}= ${TRUE}
${TESTS_IN_WINDOWS_SUPPORT}= ${TRUE}
${TESTS_IN_ESXI_SUPPORT}= ${TRUE}
${TESTS_IN_OPENWRT_SUPPORT}= ${TRUE}
@{TESTED_BSD_DISTROS}= ${ENV_ID_PFSENSE} ${ENV_ID_OPNSENSE}

# Regression test flags
${DASHARO_USB_MENU_SUPPORT}= ${TRUE}
Expand Down