Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: loot shouldn't drop for currently-dead players in BoNS #1362

Open
3 tasks done
Terrev opened this issue Dec 27, 2023 · 0 comments
Open
3 tasks done

BUG: loot shouldn't drop for currently-dead players in BoNS #1362

Terrev opened this issue Dec 27, 2023 · 0 comments
Labels
bug Something isn't working P-Fixer This issue is confirmed, but is not prioritized to be fixed.

Comments

@Terrev
Copy link
Contributor

Terrev commented Dec 27, 2023

Make sure you've done the following:

  • I have checked that this issue has not already been reported.

  • I have validated that this issue is not a syntax error of either MySQL or SQLite.

  • I have pulled the latest version of the main branch of DarkflameServer and have confirmed that the issue exists there.

DarkflameServer Version

extra emo edition

Issue Description

https://youtu.be/HAaknVJU3Ew?t=1320

https://youtu.be/VKucdAwj4t0?t=434

appears to be specified by noTeamLootOnDeath column in Activities table. if a player is dead at the moment loot is rolled, this should determine if they get loot drops from it (i.e. currently-dead players in BoNS get no loot from Kinga Hurl but likely should get loot from the final chest once it's opened, because the game revives them before that point)

is specified as 0 or 1, but more frequently, null, which should default to false according to client RE

Reproduction Steps

do the dead

Expected Behavior

lootn't

Environment

i have nothing funny to write here this time. you expect that? you even looked FORWARD to it? sucks to be you, bud. im not a fountain of comedy. i dont have the ability to make you laugh on command. i do what i can. if thats not enough for you, im sorry. but im trying. im trying my hardest. sometimes its not good enough. but we all do what we can. im sorry i let you down. anyway, windows 10

@Terrev Terrev added bug Something isn't working triage An issue that needs triage labels Dec 27, 2023
@EmosewaMC EmosewaMC added invalid This doesn't seem right P-Fixer This issue is confirmed, but is not prioritized to be fixed. and removed triage An issue that needs triage invalid This doesn't seem right labels Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P-Fixer This issue is confirmed, but is not prioritized to be fixed.
Projects
None yet
Development

No branches or pull requests

2 participants