Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for aframe 1.5.0 #6

Open
gmarty opened this issue Apr 22, 2024 · 2 comments
Open

Support for aframe 1.5.0 #6

gmarty opened this issue Apr 22, 2024 · 2 comments

Comments

@gmarty
Copy link

gmarty commented Apr 22, 2024

Hi. a-starry-sky is not compatible with the latest version of A-Frame (1.5.0). Fortunately, the only changes required to make it work are renaming some Three.js calls to API that changed.

new THREE.PlaneBufferGeometry => new THREE.PlaneGeometry
new THREE.DataTexture3D => new THREE.Data3DTexture
new THREE.IcosahedronBufferGeometry => new THREE.IcosahedronGeometry

Once that is done, it seems to work, but there may be breaking changes I haven't noticed.
@Dante83
Copy link
Owner

Dante83 commented May 1, 2024

Three always did love changing names XD. Sorry about the late reply, will try and update this over the weekend and see if it all works again. Thanks for letting me know!

@Dante83 Dante83 mentioned this issue May 6, 2024
Open
@Dante83
Copy link
Owner

Dante83 commented May 6, 2024

Something is still off and I'm not getting the sky to show up. But I implemented those changes and I can proceed next weekend to see what might have broke between these two things. There are no blaring errors, only a couple of small deprecation warnings, so I fear the problem might be a little hairy.

PR: #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmarty @Dante83