-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Total Requests should show the correct count when the skipFolders or skipRequests are used #419
Comments
Hey @gaumzi83: 👋 - Thanks for helping to make the reporter better by raising this ticket. I will take a look as soon as I can and get back to you. Cheers, Danny. |
Hey @gaumzi83 Are you reporting that those flags are not working for you or that they are not part of htmlextra.js? |
They are not working for me. So to investigate, I looked at htmlextra.js and they are not present in there. |
That file only drives the help menu on the CLI, it has nothing to do with the functionality of the reporter. Can you provide more context/information about what's not working. As you can imagine, saying it's not working doesn't really add much detail. 😅 |
By not working I mean, the reporter option "--reporter-htmlextra-skipRequests" is not skipping the request. I have provided the option with request name in following command and I expect the "send request" to be listed under the "Skipped Tests" section of the report but it is not. Instead, it is still listed under "Total Requests" section of the report. $ newman run collection.json –e environment.json –d datafile.csv –r cli,junit,htmlextra --reporter-htmlextra-skipRequests "send request" |
That's not how that flag works:
It will exclude that whole request and the data from the request, from the final report. Skipped Requests have nothing to do with Skipped Tests. You can skip a test in a request using the |
ok understood. But then it should also not appear under "Total Requests" section of the report. isn't it? |
That's a different issue but the request did actually run so the numbers are correct but the consistency is off. It's not something that I'm actively working on so the likelihood of that getting fixed in the near term is very low. Please feel free to take a look and try and fix that if you like, all PRs are welcome. |
I am new to this so I'll wait for your fix. Thank you :) |
Just to be clear, you're going to be waiting a long time if you're waiting on me :D |
Is There An Existing Issue
What Are You Seeing
The following options are not working with reporter htmlextra:
skipFolders, skipRequests and displayProgressBar
Steps To Reproduce The Issue
Looking at htmlextra.js, the above options are not present. Could these be added please else there is no point having 'Skipped Tests' section in the html report if skipRequests option is not working.
Please could you fix this if possible.
Thanks
Full Newman Command Or Node Script
$ newman run collection.json –e environment.json –d datafile.csv –r cli,junit,htmlextra --reporter-htmlextra-skipRequests "send request"
HTMLEXTRA Version
1.22.11
Newman Version
6.0.0
Additional Context
No response
The text was updated successfully, but these errors were encountered: