Skip to content

Commit 9026663

Browse files
authored
Merge pull request #26 from benr77/benr77-symfony5-support
Symfony 5.1 support
2 parents fce40e6 + c6656a8 commit 9026663

File tree

4 files changed

+19
-13
lines changed

4 files changed

+19
-13
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
Version 5.0
2+
===========
3+
* Support up to Symfony 5.1
4+
15
Version 4.2
26
===========
37
* Fix Deprecation of Request-Injection in Service Definition (thanks @benr77)

EventListener/ContextCreator.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace DZunke\FeatureFlagsBundle\EventListener;
44

55
use DZunke\FeatureFlagsBundle\Context;
6-
use Symfony\Component\HttpKernel\Event\GetResponseEvent;
6+
use Symfony\Component\HttpKernel\Event\RequestEvent;
77

88
class ContextCreator
99
{
@@ -21,9 +21,9 @@ public function __construct(Context $context)
2121
}
2222

2323
/**
24-
* @param GetResponseEvent $event
24+
* @param RequestEvent $event
2525
*/
26-
public function onKernelRequest(GetResponseEvent $event)
26+
public function onKernelRequest(RequestEvent $event)
2727
{
2828
$this->context->set('client_ip', $event->getRequest()->getClientIp());
2929
$this->context->set('hostname', $event->getRequest()->getHost());

README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ The Bundle will allow you to implement Feature Flags to your Application.
66
Please Note that there is no Interface available, so the Flags must be
77
configured directly in Symfony-Configs.
88

9-
**Use Versions >= 2.0 if Symfony 3.0 Support is wanted!**
9+
**Use Versions ^2.0 if Symfony 3.0 Support is wanted!**
10+
**Use Versions ^4.0 if Symfony 4.2 Support is wanted!**
11+
**Use Versions ^5.0 if Symfony 4.3 or 5.x Support is wanted!**
1012

1113
## Documentation
1214

@@ -15,12 +17,12 @@ configured directly in Symfony-Configs.
1517
You can add the Bundle by running [Composer](http://getcomposer.org) on your shell or adding it directly to your composer.json
1618

1719
``` bash
18-
php composer.phar require dzunke/feature-flags-bundle:dev-master
20+
php composer.phar require dzunke/feature-flags-bundle:"^5.0"
1921
```
2022

2123
``` json
2224
"require" : {
23-
"dzunke/feature-flags-bundle": "dev-master"
25+
"dzunke/feature-flags-bundle": "^5.0"
2426
}
2527
```
2628
The Namespace will be registered by autoloading with Composer but to use the integrated features for symfony you have to register the Bundle.

composer.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@
1313
],
1414
"require": {
1515
"php": ">=7.2",
16-
"symfony/http-foundation": "~4.0|~5.0",
17-
"symfony/http-kernel": "~4.0|~5.0",
18-
"symfony/dependency-injection": "~4.0|~5.0",
19-
"symfony/config": "~4.0|~5.0",
20-
"symfony/console": "~4.0|~5.0",
21-
"symfony/twig-bridge": "~4.0|~5.0",
22-
"symfony/yaml": "~4.0|~5.0"
16+
"symfony/http-foundation": "~4.3|~5.0",
17+
"symfony/http-kernel": "~4.3|~5.0",
18+
"symfony/dependency-injection": "~4.3|~5.0",
19+
"symfony/config": "~4.3|~5.0",
20+
"symfony/console": "~4.3|~5.0",
21+
"symfony/twig-bridge": "~4.3|~5.0",
22+
"symfony/yaml": "~4.3|~5.0"
2323
},
2424
"require-dev": {
2525
"twig/twig": "~2.0|~3.0",

0 commit comments

Comments
 (0)