Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localhost network - deleted Discussion behavior #361

Open
1 task done
Filipv95 opened this issue Mar 30, 2023 · 1 comment
Open
1 task done

Localhost network - deleted Discussion behavior #361

Filipv95 opened this issue Mar 30, 2023 · 1 comment

Comments

@Filipv95
Copy link
Contributor

Filipv95 commented Mar 30, 2023

Description
Create proposal from Discussion page, it should appear in Discussions Activity section.

What should happen with proposals when I delete original discussion?

ATM on localhost network. I delete discussion that has multiple Proposals attached to it, discussion dissapears.
But, from any proposal page (created from deleted Discussion) you can click Original Discussion that redirects you to deleted Discussion (title and description is loading, I guess because it's deleted).
Also, Edit Discussion is available and when I edit title/description the deleted Discussion becomes active again (visible on Governance/All discussions pages).

Steps to Reproduce

  1. Build localhost
  2. Go to Localhost Guild
  3. Click on Automation Discussion
  4. Create Proposal with Transfer action
  5. Click on Automation Discussion
  6. Delete the Automation Discussion
  7. Click on newly create Transfer proposal
  8. Click on Original Discussion button
  9. Click on Edit Discussion button
  10. Make changes to discussion title and description

Expected behavior
Not sure what should be expected behavior here, perhaps we can just remove the Original Discussion button from Proposals page, if the discussion is deleted.

Environment

  • Localhost

Device Information
OS: MacOs
Browser GoogleChrome, Brave
Device: MacOS Ventura v13.1

Additionaly unformation
Proposal created from Discussion is not visible in Activity section on localhost network

@Filipv95
Copy link
Contributor Author

Filipv95 commented Mar 30, 2023

Hey @rossneilson not sure how to label this edge-case, but it is very real situation, perhaps you have the idea how this can be handled better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant