Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal description keeps loading when the description is failed to load #358

Open
3 tasks done
yathindrak opened this issue Mar 29, 2023 · 2 comments
Open
3 tasks done
Labels
app:Frontend bug Something isn't working

Comments

@yathindrak
Copy link
Contributor

yathindrak commented Mar 29, 2023

Description
Proposal description keeps loading when the description is failed to load.

This issue has experienced in: https://project-davi.dev/#/gnosis/0x3f842726188FcD932d43bcA291be28138228e6D9/proposal/0x20a2ed6308573655e06f2cd844db8b580f08920aad086525638b8c4554a75585

The description gets null, if we inspect the ipfs cid: https://bafkreih5c6hwr3gbbwyhe76hwus7dwsgbqe46dmz5lx3ddcipn6komfdeu.ipfs.dweb.link/

This has caused for an infinite loading state.

Steps to Reproduce

Expected behavior
A clear and concise description of what you expected to happen.

It should stop showing the loading skeleton and IMO we can show that it could not load the description.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment

  • Production
  • QA
  • Develop

Device Information

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]
  • Device: [e.g. PC or mobile phone version]
@yathindrak yathindrak added bug Something isn't working app:Frontend labels Mar 29, 2023
@rossneilson
Copy link
Contributor

Seeing again here, all I did was submit a discussion then directly submit the proposal without editing the description

Screenshot 2023-03-29 at 15 34 41

@rossneilson
Copy link
Contributor

Likely we need to look at the logic for copying over description from discussions and make sure its not null somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:Frontend bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants