Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kalman filter in main already? #157

Open
jdkio opened this issue Sep 18, 2024 · 3 comments
Open

Kalman filter in main already? #157

jdkio opened this issue Sep 18, 2024 · 3 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@jdkio
Copy link
Contributor

jdkio commented Sep 18, 2024

When running main today I get a bunch of messages

Kalman filter start pos : 1840.12, -1982.16, 11368
Kalman filter end pos : 3282.12, -2024.93, 16873
Kalman filter start dir : 0.252851, -0.00802856, 0.967472
Kalman filter end dir : 0.0867626, -1.38628e-07, 0.996229
Kalman filter momentum: 5526.64 MeV
Kalman filter start pos : -961.194, -1818.2, 11368
Kalman filter end pos : -315.057, -2016.66, 14473
Kalman filter start dir : 0.196566, -0.0618855, 0.978536
Kalman filter end dir : 0.0865588, -0.103129, 0.990895
Kalman filter momentum: 6453.98 MeV

PR #122 isn't merged yet, and we don't want these numbers of messages anyway. So something's up

@jdkio jdkio added the invalid This doesn't seem right label Sep 18, 2024
@LiamOS
Copy link
Member

LiamOS commented Sep 18, 2024

Confirming there's an issue, I just went to view the Kalman PR and there's nothing to commit. One of the recent commits could have accidentally included this I guess, but unsure how we'd've missed that.

@LiamOS
Copy link
Member

LiamOS commented Sep 18, 2024

I think @AsaNehm included the Kalman filter in #135

@AsaNehm
Copy link
Contributor

AsaNehm commented Sep 18, 2024

I tried to take the Kalman filter out as much as possible, giving you the option to take it in once you're ready to do so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants