Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in monaco-editor after upgrade to 0.13.1 from version 0.12.2 #175

Open
glebcha opened this issue Feb 18, 2025 · 3 comments
Open

Errors in monaco-editor after upgrade to 0.13.1 from version 0.12.2 #175

glebcha opened this issue Feb 18, 2025 · 3 comments

Comments

@glebcha
Copy link

glebcha commented Feb 18, 2025

I have to import new modules that I don't want to be there (context menu, drag-n-drop, codelens) after upgrade to new monaco-sql-languages version.

For now I just stick to older 0.12.2 version and need further assistance to avoid unwanted behavior.

Version of monaco-editor is 0.52.2.

Thanks in advance for your help.

Required imports after upgrade:

import 'monaco-editor/esm/vs/editor/contrib/codelens/browser/codeLensCache';
import 'monaco-editor/esm/vs/editor/contrib/inlayHints/browser/inlayHintsController';
import 'monaco-editor/esm/vs/editor/common/services/treeViewsDndService';
import 'monaco-editor/esm/vs/platform/actionWidget/browser/actionWidget';
monaco-init.ts
// BEGIN_MONACO_EDITOR_FEATURES
import 'monaco-editor/esm/vs/editor/browser/coreCommands.js';
// import 'monaco-editor/esm/vs/editor/browser/widget/codeEditorWidget.js';
// import 'monaco-editor/esm/vs/editor/browser/widget/diffEditor/diffEditorWidget.js';
// import 'monaco-editor/esm/vs/editor/contrib/anchorSelect/browser/anchorSelect.js';
// import 'monaco-editor/esm/vs/editor/contrib/bracketMatching/browser/bracketMatching.js';
// import 'monaco-editor/esm/vs/editor/contrib/caretOperations/browser/caretOperations.js';
// import 'monaco-editor/esm/vs/editor/contrib/caretOperations/browser/transpose.js';
// import 'monaco-editor/esm/vs/editor/contrib/clipboard/browser/clipboard.js';
// import 'monaco-editor/esm/vs/editor/contrib/codeAction/browser/codeActionContributions.js';
// import 'monaco-editor/esm/vs/editor/contrib/codelens/browser/codelensController.js';
// import 'monaco-editor/esm/vs/editor/contrib/colorPicker/browser/colorContributions.js';
import 'monaco-editor/esm/vs/editor/contrib/comment/browser/comment.js';
import 'monaco-editor/esm/vs/editor/contrib/comment/browser/blockCommentCommand.js';
import 'monaco-editor/esm/vs/editor/contrib/comment/browser/lineCommentCommand.js';
// import 'monaco-editor/esm/vs/editor/contrib/contextmenu/browser/contextmenu.js';
// import 'monaco-editor/esm/vs/editor/contrib/cursorUndo/browser/cursorUndo.js';
// import 'monaco-editor/esm/vs/editor/contrib/dnd/browser/dnd.js';
// import 'monaco-editor/esm/vs/editor/contrib/documentSymbols/browser/documentSymbols.js';
import 'monaco-editor/esm/vs/editor/contrib/find/browser/findController.js';
// import 'monaco-editor/esm/vs/editor/contrib/folding/browser/folding.js';
// import 'monaco-editor/esm/vs/editor/contrib/fontZoom/browser/fontZoom.js';
// import 'monaco-editor/esm/vs/editor/contrib/format/browser/formatActions.js';
// import 'monaco-editor/esm/vs/editor/contrib/gotoError/browser/gotoError.js';
// import 'monaco-editor/esm/vs/editor/contrib/gotoSymbol/browser/goToCommands.js';
// import 'monaco-editor/esm/vs/editor/contrib/gotoSymbol/browser/link/goToDefinitionAtPosition.js';
// import 'monaco-editor/esm/vs/editor/contrib/hover/browser/hover.js';
// import 'monaco-editor/esm/vs/editor/contrib/inPlaceReplace/browser/inPlaceReplace.js';
// import 'monaco-editor/esm/vs/editor/contrib/indentation/browser/indentation.js';
// import 'monaco-editor/esm/vs/editor/contrib/inlayHints/browser/inlayHintsController.js';
// import 'monaco-editor/esm/vs/editor/contrib/linesOperations/browser/linesOperations.js';
// import 'monaco-editor/esm/vs/editor/contrib/linkedEditing/browser/linkedEditing.js';
// import 'monaco-editor/esm/vs/editor/contrib/links/browser/links.js';
// import 'monaco-editor/esm/vs/editor/contrib/multicursor/browser/multicursor.js';
import 'monaco-editor/esm/vs/editor/contrib/parameterHints/browser/parameterHints.js';
// import 'monaco-editor/esm/vs/editor/contrib/rename/browser/rename.js';
// import 'monaco-editor/esm/vs/editor/contrib/smartSelect/browser/smartSelect.js';
import 'monaco-editor/esm/vs/editor/contrib/snippet/browser/snippetController2.js';
import 'monaco-editor/esm/vs/editor/contrib/suggest/browser/suggestController.js';
// import 'monaco-editor/esm/vs/editor/contrib/toggleTabFocusMode/browser/toggleTabFocusMode.js';
// import 'monaco-editor/esm/vs/editor/contrib/unusualLineTerminators/browser/unusualLineTerminators.js';
// import 'monaco-editor/esm/vs/editor/contrib/semanticTokens/browser/viewportSemanticTokens.js';
// import 'monaco-editor/esm/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.js';
// import 'monaco-editor/esm/vs/editor/contrib/wordOperations/browser/wordOperations.js';
// import 'monaco-editor/esm/vs/editor/contrib/wordPartOperations/browser/wordPartOperations.js';
// import 'monaco-editor/esm/vs/editor/standalone/browser/accessibilityHelp/accessibilityHelp.js';
// import 'monaco-editor/esm/vs/editor/standalone/browser/iPadShowKeyboard/iPadShowKeyboard.js';
// import 'monaco-editor/esm/vs/editor/standalone/browser/inspectTokens/inspectTokens.js';
// import 'monaco-editor/esm/vs/editor/standalone/browser/quickAccess/standaloneCommandsQuickAccess.js';
// import 'monaco-editor/esm/vs/editor/standalone/browser/quickAccess/standaloneGotoLineQuickAccess.js';
// import 'monaco-editor/esm/vs/editor/standalone/browser/quickAccess/standaloneGotoSymbolQuickAccess.js';
// import 'monaco-editor/esm/vs/editor/standalone/browser/quickAccess/standaloneHelpQuickAccess.js';
// import 'monaco-editor/esm/vs/editor/standalone/browser/referenceSearch/standaloneReferenceSearch.js';
// import 'monaco-editor/esm/vs/editor/standalone/browser/toggleHighContrast/toggleHighContrast.js';

/** These modules should be imported
 * to avoid monaco-editor errors after upgrade
 * to [email protected] from version 0.12.2
 * */

// import 'monaco-editor/esm/vs/editor/contrib/codelens/browser/codeLensCache';
// import 'monaco-editor/esm/vs/editor/contrib/inlayHints/browser/inlayHintsController';
// import 'monaco-editor/esm/vs/editor/common/services/treeViewsDndService';
// import 'monaco-editor/esm/vs/platform/actionWidget/browser/actionWidget';
// END_MONACO_EDITOR_FEATURES

import 'monaco-sql-languages/esm/languages/trino/trino.contribution';

import { setupLanguageFeatures, LanguageIdEnum } from 'monaco-sql-languages';
// import { completionService } from './completion-service.ts';
import { initMonacoEnvironment } from './language-worker.ts';

export function initMonacoEditor() {
  initMonacoEnvironment();

  setupLanguageFeatures(LanguageIdEnum.TRINO, {
    diagnostics: false,
    // completionItems: {
    //   completionService
    // },
  });

  return null;
Screenshot with errors

Image

@liuxy0551
Copy link
Collaborator

Sorry, monaco-sql-languages is only guaranteed to work stably on [email protected] for now.

Image

@glebcha
Copy link
Author

glebcha commented Feb 19, 2025

Sorry, monaco-sql-languages is only guaranteed to work stably on [email protected] for now.

But I mentioned specially, issue comes only after monaco-sql-languages upgrade to 0.13.1.

Version 0.12.2 worked fine with latest monaco-editor as well as all previous versions do.

@liuxy0551
Copy link
Collaborator

Can you provide a minimal demo? Under what circumstances do these errors occur?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants