Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IridescentDishWithOlives is out of date #9

Open
echadwick-artist opened this issue May 2, 2023 · 4 comments
Open

IridescentDishWithOlives is out of date #9

echadwick-artist opened this issue May 2, 2023 · 4 comments

Comments

@echadwick-artist
Copy link
Collaborator

The model https://github.com/DrX3D/glTF-Sample-Assets/tree/main/Assets/IridescentDishWithOlives is out of date.

There is a newer version in this pull request KhronosGroup/glTF-Sample-Models#352 which has been converted to use the KHR_materials_iridescence extension.

The Wayfair logo has also been removed in that PR.

Thanks!

@DRx3D
Copy link
Owner

DRx3D commented May 8, 2023

It is much easier to update the content here from the existing Sample Models repo has been updated. All pending and approved model PRs should be merged soon so that the updates to this Repo can be handled.

@DRx3D
Copy link
Owner

DRx3D commented May 12, 2023

@echadwick-wayfair : Updated with the most recent PR to the Khronos glTF-Sample-Models repo

@echadwick-artist
Copy link
Collaborator Author

Thanks Leonard. The model is up to date now.

However there are a few issues:

  1. License.md and metadata.json are both missing the copyright statement. Shouldn't this be included?
  2. Summary has incorrect description. This asset uses Iridescence not Specular.
  3. Summary includes [Issues: non-Khronos mark] but the logo has been removed.
  4. Attribution text. We should include somewhere what the proper attribution is for an asset, what text the users should use for their credit line.

@DRx3D
Copy link
Owner

DRx3D commented May 17, 2023

Some of this has been fixed, but perhaps asynchronously with your comment. Maybe we should chat about what still remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants