Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control Network Object should default to GeoPandas Object #109

Open
jlaura opened this issue May 24, 2019 · 0 comments
Open

Control Network Object should default to GeoPandas Object #109

jlaura opened this issue May 24, 2019 · 0 comments

Comments

@jlaura
Copy link
Collaborator

jlaura commented May 24, 2019

We already have pandas and gdal as dependencies. We should just return the dataframe from an isis control network as a geopandas data frame. This avoids clients having to do stuff like:

gdf = gpd.GeoDataFrame(cnet, geometry=geopandas.points_from_xy(lons, lats))

This is a convenience item I believe, but will impact how we write out networks as well. We need to address #108 to confirm everything is working before adding this enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant