Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ciss2isis Broken for Early Cassini Data #5454

Closed
acpaquette opened this issue Apr 3, 2024 · 0 comments · Fixed by #5470
Closed

Ciss2isis Broken for Early Cassini Data #5454

acpaquette opened this issue Apr 3, 2024 · 0 comments · Fixed by #5470
Labels
bug Something isn't working

Comments

@acpaquette
Copy link
Collaborator

ISIS version(s) affected: 7.0.0+

Description
The changes from #4589 broke ingesting cassini ISS data that has VALID_MAXIMUM=(UNK, UNK) in the original label. These data are largely earlier images taken of the Jupiter flyby and does not persist into the later data acquisition of Saturn and its moons.

It seems like if the VALID_MAXIMUM is unknown the validMax being set in the if/else logic before #4589 should persist. I have fixed the issue locally and plan to submit a PR.

Largely I am posting this issue for potential feedback from @michaelaye

How to reproduce
Grab this image and the associated label and try to ingest the data with ciss2isis

Possible Solution
Update the ingestion program to set a default validMax then check to make sure the PVL keyword VALID_MAXIMUM is not UNK

Additional context

@acpaquette acpaquette added the bug Something isn't working label Apr 3, 2024
@acpaquette acpaquette mentioned this issue Apr 18, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant