Skip to content

Commit 3ad0b1e

Browse files
committed
[#17] bug: 리팩터링 완료 및 테스트완료
1 parent 8e631a9 commit 3ad0b1e

File tree

4 files changed

+19
-10
lines changed

4 files changed

+19
-10
lines changed

skyscanner/src/main/java/org/third/thirdseminar/controller/AirReservationController.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
package org.third.thirdseminar.controller;
22

3+
import java.util.Date;
4+
35
import lombok.RequiredArgsConstructor;
6+
7+
import org.springframework.format.annotation.DateTimeFormat;
48
import org.springframework.web.bind.annotation.*;
59
import org.third.thirdseminar.common.ApiResponse;
610
import org.third.thirdseminar.controller.dto.request.AirReservationRequest;
@@ -18,8 +22,9 @@ public class AirReservationController {
1822
private final ReservationService reservationServcie;
1923

2024
@GetMapping("/reservations")
21-
public ApiResponse<AirReservationResponse> getReservertaions(@RequestBody AirReservationRequest request){
22-
return ApiResponse.success(Success.GET_RESERVATION_SUCCESS,reservationServcie.getReservations(request));
25+
public ApiResponse<AirReservationResponse> getReservertaions(@RequestParam @DateTimeFormat(iso = DateTimeFormat.ISO.DATE) Date startDate,
26+
@RequestParam @DateTimeFormat(iso = DateTimeFormat.ISO.DATE)Date endDate){
27+
return ApiResponse.success(Success.GET_RESERVATION_SUCCESS,reservationServcie.getReservations(startDate,endDate));
2328
}
2429

2530
@PostMapping("/reservation")

skyscanner/src/main/java/org/third/thirdseminar/controller/TicketController.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
package org.third.thirdseminar.controller;
22

3+
import java.util.Date;
4+
5+
import org.springframework.format.annotation.DateTimeFormat;
36
import org.springframework.web.bind.annotation.GetMapping;
47
import org.springframework.web.bind.annotation.RequestBody;
8+
import org.springframework.web.bind.annotation.RequestParam;
59
import org.springframework.web.bind.annotation.RestController;
610
import org.third.thirdseminar.common.ApiResponse;
7-
import org.third.thirdseminar.controller.dto.request.TicketRequestDto;
811
import org.third.thirdseminar.controller.dto.response.TicketPageDto;
912
import org.third.thirdseminar.exception.Success;
1013
import org.third.thirdseminar.service.TicketService;
@@ -18,9 +21,9 @@ public class TicketController {
1821
private final TicketService ticketService;
1922

2023
@GetMapping("/ticket")
21-
public ApiResponse<TicketPageDto> getTicket(@RequestBody TicketRequestDto ticketRequestDto){
24+
public ApiResponse<TicketPageDto> getTicket(@RequestParam @DateTimeFormat(iso = DateTimeFormat.ISO.DATE) Date startDate, @RequestParam @DateTimeFormat(iso = DateTimeFormat.ISO.DATE) Date endDate, @RequestParam Long reservationId){
2225
return ApiResponse.success(Success.GET_TICKET_SUCCESS, TicketPageDto.of(
23-
ticketService.getAirInformation(ticketRequestDto),
26+
ticketService.getAirInformation(startDate,endDate,reservationId),
2427
ticketService.getTicketList())
2528
);
2629
}

skyscanner/src/main/java/org/third/thirdseminar/service/ReservationService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public class ReservationService {
3434
private final ReservationResultJpaRepository reservationResultJpaRepository;
3535
private final DecimalFormat df = new DecimalFormat("###,###");
3636

37-
public AirReservationResponse getReservations(AirReservationRequest reqeust){
37+
public AirReservationResponse getReservations(Date startDate, Date endDate){
3838
List<ReservationMinPriceDTO> reservationMinPriceDtoList = reservationJpaRepository.findReservations("일본").stream().map(
3939
row -> ReservationMinPriceDTO.of(
4040
(Reservation) row[0],
@@ -47,7 +47,7 @@ public AirReservationResponse getReservations(AirReservationRequest reqeust){
4747
Reservation reservation = reservationMinPriceDTO.reservation();
4848
airList.add(ReservationDto.of(reservation, df.format(reservationMinPriceDTO.minPrice()), TimeRangeFormat(reservation.getStartTime()), TimeRangeFormat(reservation.getEndTime())));
4949
}
50-
DateDto dateDto = new DateDto(reqeust.startDate(), reqeust.endDate());
50+
DateDto dateDto = new DateDto(startDate, endDate);
5151
return new AirReservationResponse(dateDto, airList);
5252
}
5353

skyscanner/src/main/java/org/third/thirdseminar/service/TicketService.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import java.text.DecimalFormat;
44
import java.time.format.DateTimeFormatter;
5+
import java.util.Date;
56
import java.util.List;
67
import java.util.Optional;
78
import java.util.stream.Collectors;
@@ -45,12 +46,12 @@ public List<TicketDto> getTicketList(){
4546
ticket.getComment())).collect(Collectors.toList());
4647
}
4748

48-
public AirResultDto getAirInformation(TicketRequestDto ticketRequestDto){
49-
Reservation reservation = reservationJpaRepository.findById(ticketRequestDto.reservationId())
49+
public AirResultDto getAirInformation(Date startDate, Date endDate, Long reservationId){
50+
Reservation reservation = reservationJpaRepository.findById(reservationId)
5051
.orElseThrow( ()-> new NotFoundException(Error.RESERVATION_NOT_FOUND, Error.RESERVATION_NOT_FOUND.getMessage())
5152
);
5253
Air air= reservation.getAir();
53-
DateDto dateDto = new DateDto(ticketRequestDto.startDate(), ticketRequestDto.endDate()); //date 객체 주워오기
54+
DateDto dateDto = new DateDto(startDate, endDate); //date 객체 주워오기
5455

5556
return AirResultDto.of(
5657
dateDto,

0 commit comments

Comments
 (0)