Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary JSON objects in generator_params #3

Open
jelu opened this issue May 22, 2024 · 1 comment
Open

Arbitrary JSON objects in generator_params #3

jelu opened this issue May 22, 2024 · 1 comment

Comments

@jelu
Copy link
Member

jelu commented May 22, 2024

          I would go for an arbitrary JSON object. It's up to generator how it encodes it's parameters.

Originally posted by @pspacek in #2 (comment)

@pspacek
Copy link

pspacek commented May 30, 2024

I did not realize the schema by default allows arbitrary properties. I think that mostly covers it.

With this in mind I would define an optional 'cmdline' property in the header 'header' object, make it an array of strings, and leave it up to generators to add whatever other properties they want or need.

cmdline should be optional because sometimes the command line does not exist - e.g. when the workload is generated by a library. Think e.g. of dnsjit used to send stuff to the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants